From: Christoph Hellwig <hch@infradead.org>
To: Mark Lord <lsml@rtr.ca>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2
Date: Wed, 15 Sep 2004 08:02:35 +0100 [thread overview]
Message-ID: <20040915080235.A17394@infradead.org> (raw)
In-Reply-To: <414711AC.5030200@rtr.ca>; from lsml@rtr.ca on Tue, Sep 14, 2004 at 11:43:40AM -0400
Please fix all the style issues in here, aka
- linebreaks after 80 characters
- don't typedef structs unless they're used opaqueuely
- please avoid C++-style comments even if C99 allows them
- don't use "scsi.h", only headers from <scsi/*.h>, that also
means getting rid of the Scsi_Foo typedefs
- please don't include headers in other headers unless nessecary
I also don't want another SCSI->ATA translator in drivers/scsi, please find
some way to share codce with an existing one.
I'll do a real review once the driver is readable.
next prev parent reply other threads:[~2004-09-15 7:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 15:43 [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2 Mark Lord
2004-09-14 16:21 ` Jeff Garzik
2004-09-14 16:23 ` Jeff Garzik
2004-09-14 16:39 ` Nathan Bryant
2004-09-14 17:02 ` Jeff Garzik
2004-09-15 4:22 ` Douglas Gilbert
2004-09-15 4:30 ` Jeff Garzik
2004-09-15 12:47 ` Mark Lord
2004-09-15 12:55 ` Jens Axboe
2004-09-15 13:13 ` Matthew Wilcox
2004-09-15 16:14 ` Jeff Garzik
2004-09-15 17:01 ` Jeff Garzik
2004-09-15 7:02 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-09-14 15:42 Mark Lord
2004-09-14 16:00 ` Alan Cox
2004-09-14 17:14 ` Mark Lord
2004-09-14 17:00 ` Jeff Garzik
2004-09-14 17:27 ` Mark Lord
2004-09-14 17:33 ` Jeff Garzik
2004-09-14 17:51 ` Mark Lord
2004-09-14 17:56 ` Jeff Garzik
2004-09-14 18:03 ` Mark Lord
2004-09-14 18:07 ` Jeff Garzik
2004-09-14 18:08 ` Jeff Garzik
2004-09-14 18:25 ` James Bottomley
2004-09-14 18:35 ` Jeff Garzik
2004-09-14 18:51 ` James Bottomley
2004-09-15 2:39 ` Mark Lord
2004-09-15 2:47 ` Jeff Garzik
2004-09-15 12:35 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040915080235.A17394@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lsml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.