From: James Bottomley <James.Bottomley@steeleye.com>
To: Jesse Barnes <jbarnes@engr.sgi.com>
Cc: linux-arch@vger.kernel.org
Subject: Re: [PATCH] I/O space write barrier
Date: 23 Sep 2004 15:03:51 -0400 [thread overview]
Message-ID: <1095966238.3043.26.camel@mulgrave> (raw)
In-Reply-To: <200409231448.21887.jbarnes@engr.sgi.com>
On Thu, 2004-09-23 at 14:48, Jesse Barnes wrote:
> - RD_REG_WORD(®->ictrl); /* PCI Posted Write flush */
> + mmiowb(); /* make sure this write arrives before any others */
What's going on here? In your docs you say this mmiowb() is explicitly
to prevent write ordering problems and doesn't affect posting. However
in this patch you're using it to replace a posting flush read.
> ha->flags.ints_enabled = 1;
The result will be that we can get to here, but the write that enables
the interrupt may still be posted in a bridge somewhere.
James
next prev parent reply other threads:[~2004-09-23 19:04 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-23 18:48 [PATCH] I/O space write barrier Jesse Barnes
2004-09-23 19:03 ` James Bottomley [this message]
2004-09-23 19:07 ` Jesse Barnes
2004-09-23 19:27 ` James Bottomley
2004-09-23 19:41 ` Jesse Barnes
2004-09-23 19:57 ` Jeremy Higdon
2004-09-23 22:22 ` Jeremy Higdon
2004-09-23 23:36 ` James Bottomley
2004-09-24 5:03 ` Jeremy Higdon
2004-09-23 19:55 ` Jeremy Higdon
2004-09-23 20:09 ` Jesse Barnes
2004-09-27 0:45 ` Benjamin Herrenschmidt
2004-09-27 15:41 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2004-10-21 23:13 Jesse Barnes
2004-10-21 23:13 ` Jesse Barnes
2004-10-22 1:01 ` Grant Grundler
2004-10-22 1:01 ` Grant Grundler
2004-10-22 3:05 ` Jesse Barnes
2004-10-22 3:05 ` Jesse Barnes
2004-10-22 4:26 ` Greg Banks
2004-10-22 4:26 ` Greg Banks
2004-10-22 15:26 ` Grant Grundler
2004-10-22 15:26 ` Grant Grundler
2004-10-05 22:38 Jesse Barnes
2004-10-04 20:39 Albert Cahalan
2004-10-04 21:20 ` Jesse Barnes
2004-10-05 0:32 ` Albert Cahalan
2004-10-05 1:22 ` Benjamin Herrenschmidt
2004-10-05 2:26 ` Jesse Barnes
2004-10-05 3:04 ` Benjamin Herrenschmidt
2004-10-05 15:33 ` Jesse Barnes
2004-10-05 22:41 ` Benjamin Herrenschmidt
2004-10-05 23:09 ` Jesse Barnes
2004-10-05 23:57 ` Roland Dreier
2004-10-06 1:45 ` Benjamin Herrenschmidt
2004-10-05 2:33 ` Jesse Barnes
2004-09-27 18:03 Jesse Barnes
2004-09-29 10:36 ` Greg Banks
2004-09-29 20:35 ` David S. Miller
2004-09-29 20:43 ` Jesse Barnes
2004-09-29 20:50 ` David S. Miller
2004-09-30 2:23 ` Greg Banks
2004-09-29 22:55 ` Jesse Barnes
2004-09-30 7:15 ` Jeremy Higdon
2004-09-30 21:21 ` Guennadi Liakhovetski
2004-10-16 0:38 ` Jeremy Higdon
2004-10-16 3:20 ` Matthew Wilcox
2004-10-16 3:31 ` Jeremy Higdon
2004-09-22 15:45 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095966238.3043.26.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=jbarnes@engr.sgi.com \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.