All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ulrich Hecht <uli+renesas@fpond.eu>
Cc: linux-renesas-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org, jacopo+renesas@jmondi.org,
	kieran.bingham+renesas@ideasonboard.com,
	Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
	Takeshi Kihara <takeshi.kihara.df@renesas.com>
Subject: Re: [PROTO][PATCH 07/10] arm64: dts: r8a77995-draak: set external clock for DU
Date: Mon, 20 Aug 2018 13:51:25 +0300	[thread overview]
Message-ID: <11044309.AFJYkQDyTF@avalon> (raw)
In-Reply-To: <1534254604-24204-8-git-send-email-uli+renesas@fpond.eu>

Hi Ulrich,

Thank you for the patch.

On Tuesday, 14 August 2018 16:50:01 EEST Ulrich Hecht wrote:
> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> 
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
> ---
>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index a8e8f26..bd5c6fa
> 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> @@ -2,7 +2,7 @@
>  /*
>   * Device Tree Source for the Draak board
>   *
> - * Copyright (C) 2016 Renesas Electronics Corp.
> + * Copyright (C) 2016-2018 Renesas Electronics Corp.
>   * Copyright (C) 2017 Glider bvba
>   */
> 
> @@ -269,8 +269,10 @@
> 
>  	clocks = <&cpg CPG_MOD 724>,
>  		 <&cpg CPG_MOD 723>,
> -		 <&x12_clk>;
> -	clock-names = "du.0", "du.1", "dclkin.0";
> +		 <&x12_clk>,
> +		 <&extal_clk>;
> +	clock-names = "du.0", "du.1",
> +		      "dclkin.0", "extal";

This should be moved to the LVDS encoder DT node.

>  	ports {
>  		port@0 {

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ulrich Hecht <uli+renesas@fpond.eu>
Cc: Takeshi Kihara <takeshi.kihara.df@renesas.com>,
	Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	kieran.bingham+renesas@ideasonboard.com,
	jacopo+renesas@jmondi.org
Subject: Re: [PROTO][PATCH 07/10] arm64: dts: r8a77995-draak: set external clock for DU
Date: Mon, 20 Aug 2018 13:51:25 +0300	[thread overview]
Message-ID: <11044309.AFJYkQDyTF@avalon> (raw)
In-Reply-To: <1534254604-24204-8-git-send-email-uli+renesas@fpond.eu>

Hi Ulrich,

Thank you for the patch.

On Tuesday, 14 August 2018 16:50:01 EEST Ulrich Hecht wrote:
> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> 
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
> ---
>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index a8e8f26..bd5c6fa
> 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> @@ -2,7 +2,7 @@
>  /*
>   * Device Tree Source for the Draak board
>   *
> - * Copyright (C) 2016 Renesas Electronics Corp.
> + * Copyright (C) 2016-2018 Renesas Electronics Corp.
>   * Copyright (C) 2017 Glider bvba
>   */
> 
> @@ -269,8 +269,10 @@
> 
>  	clocks = <&cpg CPG_MOD 724>,
>  		 <&cpg CPG_MOD 723>,
> -		 <&x12_clk>;
> -	clock-names = "du.0", "du.1", "dclkin.0";
> +		 <&x12_clk>,
> +		 <&extal_clk>;
> +	clock-names = "du.0", "du.1",
> +		      "dclkin.0", "extal";

This should be moved to the LVDS encoder DT node.

>  	ports {
>  		port@0 {

-- 
Regards,

Laurent Pinchart



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-08-20 14:05 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-14 13:49 [PROTO][PATCH 00/10] R-Car D3 LVDS/HDMI support (with PLL) Ulrich Hecht
2018-08-14 13:49 ` Ulrich Hecht
2018-08-14 13:49 ` [PROTO][PATCH 01/10] drm: rcar-du: Add clk_set_rate for external clock device Ulrich Hecht
2018-08-14 13:49   ` Ulrich Hecht
2018-08-20 10:10   ` Laurent Pinchart
2018-08-20 10:10     ` Laurent Pinchart
2018-08-14 13:49 ` [PROTO][PATCH 02/10] drm: rcar-du: Add r8a77995 device support Ulrich Hecht
2018-08-14 13:49   ` Ulrich Hecht
2018-08-20  8:39   ` Laurent Pinchart
2018-08-20  8:39     ` Laurent Pinchart
2018-08-14 13:49 ` [PROTO][PATCH 03/10] drm: rcar-du: Fix digital RGB routing for R8A77995 Ulrich Hecht
2018-08-14 13:49   ` Ulrich Hecht
2018-08-20  9:25   ` Laurent Pinchart
2018-08-20  9:25     ` Laurent Pinchart
2018-08-14 13:49 ` [PROTO][PATCH 04/10] drm: rcar-du: lvds: LVDS PLL support Ulrich Hecht
2018-08-14 13:49   ` Ulrich Hecht
2018-08-20 10:48   ` Laurent Pinchart
2018-08-20 10:48     ` Laurent Pinchart
2018-08-14 13:49 ` [PROTO][PATCH 05/10] drm/bridge: adv7511: Add max-clock, min-vrefresh options Ulrich Hecht
2018-08-14 13:49   ` Ulrich Hecht
2018-08-20  9:28   ` Laurent Pinchart
2018-08-20  9:28     ` Laurent Pinchart
2018-08-21  8:03     ` Ulrich Hecht
2018-08-21  8:03       ` Ulrich Hecht
2018-08-21  8:09       ` Laurent Pinchart
2018-08-21  8:09         ` Laurent Pinchart
2018-08-22  9:13         ` Ulrich Hecht
2018-08-22  9:13           ` Ulrich Hecht
2018-08-22 14:00           ` Laurent Pinchart
2018-08-22 14:00             ` Laurent Pinchart
2018-08-14 13:50 ` [PROTO][PATCH 06/10] drm: rcar-du: Fix procedure for extal and dotclkin selection Ulrich Hecht
2018-08-14 13:50   ` Ulrich Hecht
2018-08-20  9:40   ` Laurent Pinchart
2018-08-20  9:40     ` Laurent Pinchart
2018-08-14 13:50 ` [PROTO][PATCH 07/10] arm64: dts: r8a77995-draak: set external clock for DU Ulrich Hecht
2018-08-14 13:50   ` Ulrich Hecht
2018-08-20 10:51   ` Laurent Pinchart [this message]
2018-08-20 10:51     ` Laurent Pinchart
2018-08-14 13:50 ` [PROTO][PATCH 08/10] drm: rcar-du: lvds: Handle LVDS interface reset Ulrich Hecht
2018-08-14 13:50   ` Ulrich Hecht
2018-08-14 13:50 ` [PROTO][PATCH 09/10] arm64: dts: renesas: r8a77995: Add LVDS support Ulrich Hecht
2018-08-14 13:50   ` Ulrich Hecht
2018-08-14 13:50 ` [PROTO][PATCH 10/10] arm64: dts: renesas: r8a77995-draak: add HDMI output Ulrich Hecht
2018-08-14 13:50   ` Ulrich Hecht
2018-08-20 11:01   ` Laurent Pinchart
2018-08-20 11:01     ` Laurent Pinchart
2018-08-20  9:50 ` [PROTO][PATCH 00/10] R-Car D3 LVDS/HDMI support (with PLL) Laurent Pinchart
2018-08-20  9:50   ` Laurent Pinchart
2018-08-21  8:02   ` Ulrich Hecht
2018-08-21  8:02     ` Ulrich Hecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11044309.AFJYkQDyTF@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jacopo+renesas@jmondi.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=koji.matsuoka.xm@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=takeshi.kihara.df@renesas.com \
    --cc=uli+renesas@fpond.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.