From: Nigel Cunningham <ncunningham@linuxmail.org>
To: sfeldma@pobox.com
Cc: "David Härdeman" <david@2gen.com>,
"Michael Gernoth" <simigern@stud.uni-erlangen.de>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
netdev@oss.sgi.com
Subject: Re: 2.4.29, e100 and a WOL packet causes keventd going mad
Date: Mon, 31 Jan 2005 17:14:16 +1100 [thread overview]
Message-ID: <1107152056.21273.56.camel@desktop.cunninghams> (raw)
In-Reply-To: <1107147615.18167.433.camel@localhost.localdomain>
Hi.
On Mon, 2005-01-31 at 16:00, Scott Feldman wrote:
> On Sun, 2005-01-30 at 19:58, Nigel Cunningham wrote:
> > Do you also disable the WOL event when resuming?
>
> Good catch. How's this look?
I looked at it last week because I used it for an example of device
model drivers at the CELF conference. I got your intel address from the
top of the .c file, but IIRC it bounced. Providence :>
[...]
> @@ -2333,6 +2331,7 @@ static int e100_resume(struct pci_dev *p
> struct nic *nic = netdev_priv(netdev);
>
> pci_set_power_state(pdev, PCI_D0);
> + pci_enable_wake(pdev, PCI_D0, 0);
> pci_restore_state(pdev);
> e100_hw_init(nic);
Shouldn't this be disable_wake?
Regards,
Nigel
--
Nigel Cunningham
Software Engineer, Canberra, Australia
http://www.cyclades.com
Ph: +61 (2) 6292 8028 Mob: +61 (417) 100 574
next prev parent reply other threads:[~2005-01-31 6:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-30 17:18 2.4.29, e100 and a WOL packet causes keventd going mad David Härdeman
2005-01-31 3:47 ` Scott Feldman
2005-01-31 3:58 ` Nigel Cunningham
2005-01-31 5:00 ` Scott Feldman
2005-01-31 6:14 ` Nigel Cunningham [this message]
2005-01-31 9:08 ` Nigel Cunningham
2005-01-31 4:23 ` Bukie Mabayoje
2005-01-31 15:24 ` Marcelo Tosatti
2005-01-31 20:29 ` David Härdeman
2005-01-31 21:13 ` Bukie Mabayoje
-- strict thread matches above, loose matches on Subject: below --
2005-01-31 19:26 Brandeburg, Jesse
2005-01-31 20:57 ` Bukie Mabayoje
2005-01-28 16:48 Michael Gernoth
2005-01-28 18:53 ` Bukie Mabayoje
2005-01-28 18:54 ` Michael Gernoth
2005-01-28 20:05 ` Bukie Mabayoje
2005-01-30 0:13 ` Bukie Mabayoje
2005-01-29 18:18 ` Marcelo Tosatti
2005-01-30 12:15 ` Michael Gernoth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107152056.21273.56.camel@desktop.cunninghams \
--to=ncunningham@linuxmail.org \
--cc=david@2gen.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=sfeldma@pobox.com \
--cc=simigern@stud.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.