Re: [Bluez-devel] Connection with aphonestaysopenafterclosingRFCOMM channel

Re: [Bluez-devel] Connection with aphonestaysopenafterclosingRFCOMM channel

[Victor Shcherbatyuk]

And now with modules:

_before:

Module                  Size  Used by
rfcomm                 35100  0 
hidp                   27136  2 
l2cap                  23044  10 rfcomm,hidp
hci_usb                12744  2 
bluetooth              43908  8 rfcomm,hidp,l2cap,hci_usb

_listening:

Module                  Size  Used by
rfcomm                 35100  3 
hidp                   27136  2 
l2cap                  23044  10 rfcomm,hidp
hci_usb                12744  2 
bluetooth              43908  8 rfcomm,hidp,l2cap,hci_usb

_connected:

Module                  Size  Used by
rfcomm                 35100  3 
hidp                   27136  2 
l2cap                  23044  12 rfcomm,hidp
hci_usb                12744  3 
bluetooth              43908  8 rfcomm,hidp,l2cap,hci_usb

_afrer:

Module                  Size  Used by
rfcomm                 35100  1                  <---------- ?
hidp                   27136  2 
l2cap                  23044  12 rfcomm,hidp
hci_usb                12744  3 
bluetooth              43908  8 rfcomm,hidp,l2cap,hci_usb


Hope that explains....

Regards,

Victor.


----- Original Message ----- 
From: "Marcel Holtmann" <marcel@holtmann.org>
To: "BlueZ Mailing List" <bluez-devel@lists.sourceforge.net>
Sent: Thursday, March 03, 2005 00:54
Subject: Re: [Bluez-devel] Connection with 
aphonestaysopenafterclosingRFCOMM channel


> Hi Victor,
> 
>> 2.6.10-mh4  - did not help
> 
> so this is still a problem with the current Bluetooth subsystem.
> 
>> lsmod - /proc/modules is empty, but i have no modules (everything i 
>> need is compiled into kernel)...
> 
> Too bad, because I don't know of any other way to check the module
> reference counting. If there is something wrong we would be sure that I
> have to look for that.
> 
>> l2cap:
>> 72:FF:28:C6:10:00 42:E4:11:DE:0F:00 1 3 0x0040 0x0043 1024 251 0x0
>> 00:00:00:00:00:00 00:00:00:00:00:00 4 19 0x0000 0x0000 48 48 0x0
>> 00:00:00:00:00:00 00:00:00:00:00:00 4 17 0x0000 0x0000 48 48 0x0
>> 00:00:00:00:00:00 00:00:00:00:00:00 4 1 0x0000 0x0000 672 0 0x0
>> 00:00:00:00:00:00 00:00:00:00:00:00 4 3 0x0000 0x0000 1024 0 0x0
> 
> The L2CAP PSM 3 for RFCOMM is still connected. It's actually that what I
> expected.
> 
>> Am I missing something?
> 
> No, because we should simply close the DLCI 0 when no other RFCOMM
> channel is open.
> 
> Regards
> 
> Marcel
> 
> 
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Bluez-devel mailing list
> Bluez-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bluez-devel

-- 




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] Connection with aphonestaysopenafterclosingRFCOMM channel

[Marcel Holtmann]

Hi Victor,

> And now with modules:
> 
> _before:
> 
> Module                  Size  Used by
> rfcomm                 35100  0 
> hidp                   27136  2 
> l2cap                  23044  10 rfcomm,hidp
> hci_usb                12744  2 
> bluetooth              43908  8 rfcomm,hidp,l2cap,hci_usb
> 
> _listening:
> 
> Module                  Size  Used by
> rfcomm                 35100  3 
> hidp                   27136  2 
> l2cap                  23044  10 rfcomm,hidp
> hci_usb                12744  2 
> bluetooth              43908  8 rfcomm,hidp,l2cap,hci_usb
> 
> _connected:
> 
> Module                  Size  Used by
> rfcomm                 35100  3 
> hidp                   27136  2 
> l2cap                  23044  12 rfcomm,hidp
> hci_usb                12744  3 
> bluetooth              43908  8 rfcomm,hidp,l2cap,hci_usb
> 
> _afrer:
> 
> Module                  Size  Used by
> rfcomm                 35100  1                  <---------- ?
> hidp                   27136  2 
> l2cap                  23044  12 rfcomm,hidp
> hci_usb                12744  3 
> bluetooth              43908  8 rfcomm,hidp,l2cap,hci_usb
> 
> 
> Hope that explains....

it does not explain it, but this is what I expected. Another reference
counting problem. Maybe introduced at that time I fixed another one of
these crazy problems. Funny is that this does not result in an oops. The
easiest way to fix this is, if you send me one of these phones, because
otherwise it will take quite some time to reproduce it.

Regards

Marcel




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] Connection with aphonestaysopenafterclosingRFCOMM channel

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

Hi Victor,

> > Hope that explains....
> 
> it does not explain it, but this is what I expected. Another reference
> counting problem. Maybe introduced at that time I fixed another one of
> these crazy problems. Funny is that this does not result in an oops. The
> easiest way to fix this is, if you send me one of these phones, because
> otherwise it will take quite some time to reproduce it.

try the attached patch. It fixes it for me when I tested this with a
Nokia 6310.

Regards

Marcel


[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 436 bytes --]

===== net/bluetooth/rfcomm/core.c 1.49 vs edited =====
--- 1.49/net/bluetooth/rfcomm/core.c	2005-01-23 19:59:56 +01:00
+++ edited/net/bluetooth/rfcomm/core.c	2005-03-09 11:27:46 +01:00
@@ -389,6 +389,8 @@
 		rfcomm_dlc_unlock(d);
 
 		skb_queue_purge(&d->tx_queue);
+		rfcomm_session_put(s);
+
 		rfcomm_dlc_unlink(d);
 	}
 
@@ -597,6 +599,8 @@
 		*err = -ENOMEM;
 		goto failed;
 	}
+
+	rfcomm_session_hold(s);
 
 	s->initiator = 1;