From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>, Len Brown <len.brown@intel.com>,
"Luck, Tony" <tony.luck@intel.com>, Greg KH <greg@kroah.com>,
acpi-devel@lists.sourceforge.net, linux-ia64@vger.kernel.org,
pcihpd-discuss@lists.sourceforge.net
Subject: Re: [ACPI] [RFC/PATCH 1/3] ACPI based I/O APIC hot-plug
Date: Thu, 21 Apr 2005 11:21:31 -0600 [thread overview]
Message-ID: <1114104091.2784.40.camel@eeyore> (raw)
In-Reply-To: <4267AD13.5080900@jp.fujitsu.com>
> +++ linux-2.6.12-rc2-mm3-kanesige/arch/ia64/kernel/acpi.c 2005-04-20 10:51:30.136299152 +0900
> @@ -892,4 +892,21 @@ acpi_map_iosapic (acpi_handle handle, u3
> return AE_OK;
> }
> #endif /* CONFIG_NUMA */
> +
> +int
> +acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base)
> +{
> + /* TBD */
> + return -EINVAL;
> +}
> +EXPORT_SYMBOL(acpi_register_ioapic);
> +
> +int
> +acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base)
Nitpick: these declarations should follow the style of the rest
of the file, i.e., add a space between the function name and the
opening parenthesis.
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>, Len Brown <len.brown@intel.com>,
"Luck, Tony" <tony.luck@intel.com>, Greg KH <greg@kroah.com>,
acpi-devel@lists.sourceforge.net, linux-ia64@vger.kernel.org,
pcihpd-discuss@lists.sourceforge.net
Subject: Re: [ACPI] [RFC/PATCH 1/3] ACPI based I/O APIC hot-plug
Date: Thu, 21 Apr 2005 17:21:31 +0000 [thread overview]
Message-ID: <1114104091.2784.40.camel@eeyore> (raw)
In-Reply-To: <4267AD13.5080900@jp.fujitsu.com>
> +++ linux-2.6.12-rc2-mm3-kanesige/arch/ia64/kernel/acpi.c 2005-04-20 10:51:30.136299152 +0900
> @@ -892,4 +892,21 @@ acpi_map_iosapic (acpi_handle handle, u3
> return AE_OK;
> }
> #endif /* CONFIG_NUMA */
> +
> +int
> +acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base)
> +{
> + /* TBD */
> + return -EINVAL;
> +}
> +EXPORT_SYMBOL(acpi_register_ioapic);
> +
> +int
> +acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base)
Nitpick: these declarations should follow the style of the rest
of the file, i.e., add a space between the function name and the
opening parenthesis.
next prev parent reply other threads:[~2005-04-21 17:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-21 13:39 [RFC/PATCH 1/3] ACPI based I/O APIC hot-plug Kenji Kaneshige
2005-04-21 13:39 ` Kenji Kaneshige
2005-04-21 17:21 ` Bjorn Helgaas [this message]
2005-04-21 17:21 ` [ACPI] " Bjorn Helgaas
2005-04-22 6:38 ` Kenji Kaneshige
2005-04-22 6:38 ` Kenji Kaneshige
2005-04-22 7:53 ` [Pcihpd-discuss] " Rolf Eike Beer
2005-04-22 7:53 ` Rolf Eike Beer
[not found] ` <200504220953.20831-rMKJyNB0tZ8LKYO4ye7UPbyZi+5vbtHrhC4ANOJQIlc@public.gmane.org>
2005-04-22 14:56 ` [Pcihpd-discuss] " Bjorn Helgaas
2005-04-22 14:56 ` [Pcihpd-discuss] Re: [ACPI] [RFC/PATCH 1/3] ACPI based I/O Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114104091.2784.40.camel@eeyore \
--to=bjorn.helgaas@hp.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.