From: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
To: Rolf Eike Beer <eike-hotplug-F+mm6HnICJmzQB+pC5nmwQ@public.gmane.org>
Cc: pcihpd-discuss-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Kenji Kaneshige
<kaneshige.kenji-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Luck, Tony" <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>,
acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Pcihpd-discuss] Re: [RFC/PATCH 1/3] ACPI based I/O APIC hot-plug
Date: Fri, 22 Apr 2005 08:56:19 -0600 [thread overview]
Message-ID: <1114181779.4902.1.camel@eeyore> (raw)
In-Reply-To: <200504220953.20831-rMKJyNB0tZ8LKYO4ye7UPbyZi+5vbtHrhC4ANOJQIlc@public.gmane.org>
On Fri, 2005-04-22 at 09:53 +0200, Rolf Eike Beer wrote:
> Am Freitag, 22. April 2005 08:38 schrieb Kenji Kaneshige:
> > Hi Bjorn,
>
> > > Nitpick: these declarations should follow the style of the rest
> > > of the file, i.e., add a space between the function name and the
> > > opening parenthesis.
> >
> > Thank you very much for comments.
> > I'll update my patches based on your comments.
>
> No, please don't do this. It just causes me to send another patch to kill them
> alltogether.
Don't be silly. If you want to change the whole file to conform to
one style, fine. I even agree with the sentiment that arch/ia64
would be better off if it were more consistent with the rest of the
kernel.
But isolated changes to a file should follow the style of the rest
of the file.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Rolf Eike Beer <eike-hotplug-F+mm6HnICJmzQB+pC5nmwQ@public.gmane.org>
Cc: pcihpd-discuss-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Kenji Kaneshige
<kaneshige.kenji-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Luck, Tony" <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>,
acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Pcihpd-discuss] Re: [ACPI] [RFC/PATCH 1/3] ACPI based I/O
Date: Fri, 22 Apr 2005 14:56:19 +0000 [thread overview]
Message-ID: <1114181779.4902.1.camel@eeyore> (raw)
In-Reply-To: <200504220953.20831-rMKJyNB0tZ8LKYO4ye7UPbyZi+5vbtHrhC4ANOJQIlc@public.gmane.org>
On Fri, 2005-04-22 at 09:53 +0200, Rolf Eike Beer wrote:
> Am Freitag, 22. April 2005 08:38 schrieb Kenji Kaneshige:
> > Hi Bjorn,
>
> > > Nitpick: these declarations should follow the style of the rest
> > > of the file, i.e., add a space between the function name and the
> > > opening parenthesis.
> >
> > Thank you very much for comments.
> > I'll update my patches based on your comments.
>
> No, please don't do this. It just causes me to send another patch to kill them
> alltogether.
Don't be silly. If you want to change the whole file to conform to
one style, fine. I even agree with the sentiment that arch/ia64
would be better off if it were more consistent with the rest of the
kernel.
But isolated changes to a file should follow the style of the rest
of the file.
next prev parent reply other threads:[~2005-04-22 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-21 13:39 [RFC/PATCH 1/3] ACPI based I/O APIC hot-plug Kenji Kaneshige
2005-04-21 13:39 ` Kenji Kaneshige
2005-04-21 17:21 ` [ACPI] " Bjorn Helgaas
2005-04-21 17:21 ` Bjorn Helgaas
2005-04-22 6:38 ` Kenji Kaneshige
2005-04-22 6:38 ` Kenji Kaneshige
2005-04-22 7:53 ` [Pcihpd-discuss] " Rolf Eike Beer
2005-04-22 7:53 ` Rolf Eike Beer
[not found] ` <200504220953.20831-rMKJyNB0tZ8LKYO4ye7UPbyZi+5vbtHrhC4ANOJQIlc@public.gmane.org>
2005-04-22 14:56 ` Bjorn Helgaas [this message]
2005-04-22 14:56 ` [Pcihpd-discuss] Re: [ACPI] [RFC/PATCH 1/3] ACPI based I/O Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114181779.4902.1.camel@eeyore \
--to=bjorn.helgaas-vxdhtt5mjny@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=akpm-3NddpPZAyC0@public.gmane.org \
--cc=eike-hotplug-F+mm6HnICJmzQB+pC5nmwQ@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=kaneshige.kenji-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pcihpd-discuss-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.