Re: What breaks aic7xxx in post 2.6.12-rc2 ?

[James Bottomley <James.Bottomley@SteelEye.com>]

On Mon, 2005-06-13 at 23:33 +0200, Gregoire Favre wrote:
> On Mon, Jun 13, 2005 at 03:50:47PM -0500, James Bottomley wrote:
> I was really sure I should work and I booted it without the console
> switch to log on my palm, so I miss the beginning of the log, I hope
> this dmesg is enough (yes, this time it booted perfectly, thank you very
> much) :-)
> 
> I wonder if the speed read for my first controller with U2 and U160
> drive are right ?

No ... unfortunately there's a precedence bug in the u160 code ...

Try the attached (on top of everything else).

Thanks,

James

diff -u b/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
--- b/drivers/scsi/aic7xxx/aic7xxx_osm.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
@@ -640,7 +640,7 @@
 		}
 	    
 		if ((ahc->features & AHC_ULTRA2) != 0) {
-			scsirate = (flags & CFXFER) | ultra ? 0x8 : 0;
+			scsirate = (flags & CFXFER) | (ultra ? 0x8 : 0);
 			dev_printk(KERN_ERR, &starget->dev, "ULTRA2, flags 0x%x\n", flags);
 		} else {
 			scsirate = (flags & CFXFER) << 4;