Re: [ckrm-tech] [PATCH 4/6] CKRM: Add guarantee support for mem controller

[Chandra Seetharaman <sekharan@us.ibm.com>]

On Thu, 2005-06-30 at 14:52 +0900, YAMAMOTO Takashi wrote:
> > +static inline void
> > +ckrm_clear_page_class(struct page *page)
> > +{
> > +	struct ckrm_zone *czone = page_ckrmzone(page);
> > +	if (czone == NULL)
> > +		return;
> > +	sub_use_count(czone->memcls, 0, page_zonenum(page), 1);
> > +	kref_put(&czone->memcls->nr_users, memclass_release);
> > +	set_page_ckrmzone(page, NULL);
> >  }
> 
> are you sure if it's safe?
> this function is called with zone->lock held,
> and memclass_release calls kfree.

i don't understand why you think it is a problem to call kfree with lock
held( i agree calling kmalloc with wait flag when a lock is being held
is not correct).

> 
> YAMAMOTO Takashi
-- 

----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - sekharan@us.ibm.com   |      .......you may get it.
----------------------------------------------------------------------


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>