Re: [ckrm-tech] [PATCH 4/6] CKRM: Add guarantee support for mem controller

[Dave Hansen <haveblue@us.ibm.com>]

On Thu, 2005-06-30 at 12:21 -0700, Chandra Seetharaman wrote:
> Hmm.... either you are looking at a old set of patches or you do not
> have all the patches in the current set. ckrm_clear_page_class is _not_
> from free_pages_bulk in the current patchset fully applied :).

I was looking at the patches individually.

> chandra
> PS: it should not be there in any of the patches in the current
> patchset, but is left out due to code rearrangements, I will fix that.

I find the whole patch set really hard to understand.  It seems more
like a linear set of how you wrote it and fixed it, rather than broken
up into logical components.

For instance, what does "Add guarantee support for mem-controller" have
to do with removing ckrm_clear_page_class() from the allocator path?

If there was a reason that you remove that function from
__free_pages_bulk(), because of a bug fix, it needs to go into a
separate patch.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>