Re: [ckrm-tech] [PATCH 4/6] CKRM: Add guarantee support for mem controller

[Chandra Seetharaman <sekharan@us.ibm.com>]

On Thu, 2005-06-30 at 12:02 -0700, Dave Hansen wrote:

> > memory controller does not use zone->lock, it only uses zone->lru_lock..
> > I 'll look thru to see if that leads to a deadlock...
> 
> static int
> free_pages_bulk(struct zone *zone, int count,
>                 struct list_head *list, unsigned int order)
> {
> ...
>         spin_lock_irqsave(&zone->lock, flags);
>         while (!list_empty(list) && count--) {
> 		__free_pages_bulk(page, zone, order);
> 
> 		/* can't call the allocator in here: /*
> 		(page);
>         }
>         spin_unlock_irqrestore(&zone->lock, flags);
>         return ret;
> }
> 
> See?

Hmm.... either you are looking at a old set of patches or you do not
have all the patches in the current set. ckrm_clear_page_class is _not_
from free_pages_bulk in the current patchset fully applied :).

chandra
PS: it should not be there in any of the patches in the current
patchset, but is left out due to code rearrangements, I will fix that.
> 
> -- Dave
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
-- 

----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - sekharan@us.ibm.com   |      .......you may get it.
----------------------------------------------------------------------


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>