Re: [PATCH] WM97xx AC97 codec controls

[Liam Girdwood <liam.girdwood@wolfsonmicro.com>]

On Wed, 2005-07-27 at 12:07 +0200, Takashi Iwai wrote:

> I found that the control names you added don't follow always the
> standard rule.  Namely,
> 
> - "XXX Vol" should be "XXX Volume"
> - "XXX Mute" should be "XXX Switch" in the inversed way
>   (unless it becomes confusing)
> 
> Using "Volume" or "Switch" suffix is important because the mixer
> abstraction layer detects the type of the control from such a name 
> suffix.
> 
> Could you fix these?

np.

I've just had a look the list of control types (in hcontrol.c) and I
think I've got a couple of types in the patch that are missing:-

  o ALC/NG - Automatic Level Control and Noise Gate controls. ALC
attack, decay and hold are measured in time instead of volume. 
  o ZC - Zero Cross controls (becoming more popular in codecs)

I could add "ALC", "NG", "ZC" and "Time" (or similar) to hcontrol.c, but
I'm not sure if it requires more than just adding strings.

Liam
 



-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click