Re: [PATCH] WM97xx AC97 codec controls

[Takashi Iwai <tiwai@suse.de>]

At Thu, 28 Jul 2005 16:43:05 +0100,
Liam Girdwood wrote:
> 
> I've now made the suggested changes and have used the suffix naming
> convention for the controls. I've also added AC97_HAS_NO_STD_PCM, since
> the wm9713 uses this register for another purpose and replaced some
> double mono controls with stereo equivalents.

Thanks!

Still I see minor problems:

- The standard control name for PCM volume is "PCM Playback Volume".
  Ditto for Front, Rear, etc.  But I don't think it's necessary for
  the controls like "Aux To Headphone" - the direction is not obvious
  in such a case.

  Similarly, PCM switch should be "PCM Playback Switch".

  Also, you don't have to be too nervous about "Switch" suffix.  It's
  mandatory only if the volume control with same component exists, or
  if its name is not obvious as a switch.

- PCM switch is supposed to be reversed from mute switch.  If it's 1,
  PCM is turned ON.  Thus the last argument (invert) of AC97_SINGLE()
  should be 0.


Care to fix the above?

thanks,

Takashi


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September
19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf