Re: [PATCH] WM97xx AC97 codec controls

[Takashi Iwai <tiwai@suse.de>]

At Thu, 28 Jul 2005 20:26:30 +0100,
Liam Girdwood wrote:
> 
> On Thu, 2005-07-28 at 18:02 +0200, Takashi Iwai wrote:
> 
> > 
> > - PCM switch is supposed to be reversed from mute switch.  If it's 1,
> >   PCM is turned ON.  Thus the last argument (invert) of AC97_SINGLE()
> >   should be 0.
> > 
> 
> It's the opposite in AC97. 1 = mute and 0 = on. Hence all of the mute
> switches are inverted. Unless I misunderstood...

Ah, then it should be OK.

> Changes:-
>  
>   o Enhanced current WM97xx support to provide additional controls and
> use the kcontrol suffix naming convention.
>   o Added AC97_HAS_NO_MIC, AC97_HAS_NO_TONE and AC97_HAS_NO_STD_PCM.
>   o Cleaned up WM97xx related comments.
>   o Removed some wm9713 double mono controls and replaced with stereo
> controls.
> 
> Signed-off-by: Liam Girdwood <liam.girdwood@wolfsonmicro.com>

Applied to CVS now.  Thanks!


Takashi


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September
19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf