[PATCH] DEC hsg80 needs BLIST_REPORTLUN2

[PATCH] DEC hsg80 needs BLIST_REPORTLUN2

[Steve Wilcox]

In order to properly report LUN's > 7, the DEC HSG80 definition in
scsi_devinfo.c needs to include BLIST_REPORTLUN2 rather than
BLIST_SPARSELUN.  I've tested this change with several HSG firmware
revisions and with both Emulex and Qlogic HBA's.

-Steve


--- /drivers/scsi/scsi_devinfo.c 2005-05-09 12:28:15.000000000 -0400
+++ /drivers/scsi/scsi_devinfo.c 2005-05-09 12:29:03.000000000 -0400
@@ -135,7 +135,7 @@ static struct {
	{"COMPAQ", "MSA1000 VOLUME", NULL, BLIST_SPARSELUN |
BLIST_NOSTARTONADD},
	{"COMPAQ", "HSV110", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
	{"DDN", "SAN DataDirector", "*", BLIST_SPARSELUN},
-	{"DEC", "HSG80", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
+	{"DEC", "HSG80", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
	{"DELL", "PV660F", NULL, BLIST_SPARSELUN},
	{"DELL", "PV660F PSEUDO", NULL, BLIST_SPARSELUN},
	{"DELL", "PSEUDO DEVICE .", NULL, BLIST_SPARSELUN}, /* Dell PV 530F */

Re: [PATCH] DEC hsg80 needs BLIST_REPORTLUN2

[James Bottomley]

On Tue, 2005-08-09 at 13:26 -0400, Steve Wilcox wrote:
> In order to properly report LUN's > 7, the DEC HSG80 definition in
> scsi_devinfo.c needs to include BLIST_REPORTLUN2 rather than
> BLIST_SPARSELUN.  I've tested this change with several HSG firmware
> revisions and with both Emulex and Qlogic HBA's.

Well, your patch won't apply.  Apart from the breaking by the mailer,
you have a curiosity in the last three lines (the DELL arrays) which are
definitely missing tabs and spaces over what we have in the kernel
(There are three spaces between "PV660F" and "PSEUDO" and there's a tab
not a space before the comment).  How did you generate this diff?

Anyway, I can apply the single change manually.

James

Re: [PATCH] DEC hsg80 needs BLIST_REPORTLUN2

[Wilcox, Stephen P, CITPC]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

Crap.  I was afraid that my mailer might mangle this...   I created the
patch with "diff -up" based on the info in "SubmittingPatches" in the
kernel source tree, but I must admit that I manually edited the patch so
that It would apply to RedHat's .src.rpms using their canned spec files.
The working (at least using RedHat's method) patch is attached this time
rather than pasted in.  If that one still fails to work, the single
change is all that's really needed.

-steve



On Tue, 2005-08-09 at 12:51 -0500, James Bottomley wrote:
> On Tue, 2005-08-09 at 13:26 -0400, Steve Wilcox wrote:
> > In order to properly report LUN's > 7, the DEC HSG80 definition in
> > scsi_devinfo.c needs to include BLIST_REPORTLUN2 rather than
> > BLIST_SPARSELUN.  I've tested this change with several HSG firmware
> > revisions and with both Emulex and Qlogic HBA's.
> 
> Well, your patch won't apply.  Apart from the breaking by the mailer,
> you have a curiosity in the last three lines (the DELL arrays) which are
> definitely missing tabs and spaces over what we have in the kernel
> (There are three spaces between "PV660F" and "PSEUDO" and there's a tab
> not a space before the comment).  How did you generate this diff?
> 
> Anyway, I can apply the single change manually.
> 
> James
> 
> 

[-- Attachment #2: Replaced Blocked File.txt --]
[-- Type: text/plain, Size: 511 bytes --]

********               McAfee GroupShield Exchange          **********
********  Alert generated at: Tuesday, August 09, 2005 01:29:05 PM Central Daylight Time
**********************************************************************


The file scsi-blacklist.patch has been replaced, as it is a file type that is known for spreading viruses. For assistance, please contact your local Desktop Support Personnel or refer to the following website for direction. http://antivirus.security.att.com/Default.htm

Re: [PATCH] DEC hsg80 needs BLIST_REPORTLUN2

[James Bottomley]

On Tue, 2005-08-09 at 13:29 -0500, Wilcox, Stephen P, CITPC wrote:
> Crap.  I was afraid that my mailer might mangle this...   I created the
> patch with "diff -up" based on the info in "SubmittingPatches" in the
> kernel source tree, but I must admit that I manually edited the patch so
> that It would apply to RedHat's .src.rpms using their canned spec files.
> The working (at least using RedHat's method) patch is attached this time
> rather than pasted in.  If that one still fails to work, the single
> change is all that's really needed.

Well, apparently your ISP mangles attachments:

> The file scsi-blacklist.patch has been replaced, as it is a file type
> that is known for spreading viruses. For assistance, please contact
> your local Desktop Support Personnel or refer to the following website
> for direction. http://antivirus.security.att.com/Default.htm
> 

However I think I have this patch here:

http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=67f4602a392008439ab030ab23181f75e330ba74

If you just verify I got it right.

James

Re: [PATCH] DEC hsg80 needs BLIST_REPORTLUN2

[Steve Wilcox]

That one looks good.  Thanks for all of your help there.

-steve

On Tue, 2005-08-09 at 13:36 -0500, James Bottomley wrote:
> On Tue, 2005-08-09 at 13:29 -0500, Wilcox, Stephen P, CITPC wrote:
> > Crap.  I was afraid that my mailer might mangle this...   I created the
> > patch with "diff -up" based on the info in "SubmittingPatches" in the
> > kernel source tree, but I must admit that I manually edited the patch so
> > that It would apply to RedHat's .src.rpms using their canned spec files.
> > The working (at least using RedHat's method) patch is attached this time
> > rather than pasted in.  If that one still fails to work, the single
> > change is all that's really needed.
> 
> Well, apparently your ISP mangles attachments:
> 
> > The file scsi-blacklist.patch has been replaced, as it is a file type
> > that is known for spreading viruses. For assistance, please contact
> > your local Desktop Support Personnel or refer to the following website
> > for direction. http://antivirus.security.att.com/Default.htm
> > 
> 
> However I think I have this patch here:
> 
> http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=67f4602a392008439ab030ab23181f75e330ba74
> 
> If you just verify I got it right.
> 
> James
> 
>