All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerone Young <jyoung5@us.ibm.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] code tidyness xen/tools/symbol.c
Date: Thu, 11 Aug 2005 10:56:42 -0500	[thread overview]
Message-ID: <1123775802.3043.16.camel@thinkpad> (raw)

Fix where "!" operator used in Bitwise operation. 

In IBM we have an internal source code scanner called BEAM. We have run
it against Xen and here are some of the results.

Signed-off-by: Jerone Young <jyoung5@us.ibm.com>

--- xen/tools/symbols.c.old     2005-08-11 07:42:27.000000000 -0500
+++ xen/tools/symbols.c 2005-08-11 08:06:46.000000000 -0500
@@ -311,7 +311,7 @@ write_src(void)
        off = 0;
        for (i = 0; i < cnt; i++) {

-               if (!table[i].flags & SYM_FLAG_VALID)
+               if (!(table[i].flags & SYM_FLAG_VALID))
                        continue;

                if ((valid & 0xFF) == 0)



-- 
Jerone Young
IBM Linux Technology Center
jyoung5@us.ibm.com
512-838-1157 (T/L: 678-1157)

                 reply	other threads:[~2005-08-11 15:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1123775802.3043.16.camel@thinkpad \
    --to=jyoung5@us.ibm.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.