* [PATCH] code tidyness xen/tools/symbol.c
@ 2005-08-11 15:56 Jerone Young
0 siblings, 0 replies; only message in thread
From: Jerone Young @ 2005-08-11 15:56 UTC (permalink / raw)
To: xen-devel
Fix where "!" operator used in Bitwise operation.
In IBM we have an internal source code scanner called BEAM. We have run
it against Xen and here are some of the results.
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
--- xen/tools/symbols.c.old 2005-08-11 07:42:27.000000000 -0500
+++ xen/tools/symbols.c 2005-08-11 08:06:46.000000000 -0500
@@ -311,7 +311,7 @@ write_src(void)
off = 0;
for (i = 0; i < cnt; i++) {
- if (!table[i].flags & SYM_FLAG_VALID)
+ if (!(table[i].flags & SYM_FLAG_VALID))
continue;
if ((valid & 0xFF) == 0)
--
Jerone Young
IBM Linux Technology Center
jyoung5@us.ibm.com
512-838-1157 (T/L: 678-1157)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-08-11 15:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-11 15:56 [PATCH] code tidyness xen/tools/symbol.c Jerone Young
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.