* code question xen/arch/x86/vmx.c
@ 2005-08-11 21:48 Jerone Young
2005-08-11 21:47 ` Keir Fraser
0 siblings, 1 reply; 3+ messages in thread
From: Jerone Young @ 2005-08-11 21:48 UTC (permalink / raw)
To: xen-devel
In function vmx_dr_access in xen/arch/x86/vmx.c there is a long pointer
named "reg_p". reg_p is assigned to
v->arch.guest_context.debugreg[reg] = *reg_p;
in the switch case TYPE_MOV_TO_DR.
yet it has no assignment before this? What is the intent of reg_p?
It also is assigned in the switch case TYPE_MOVE_FROM_DR...yet it's not
used for anything ?
--
Jerone Young
IBM Linux Technology Center
jyoung5@us.ibm.com
512-838-1157 (T/L: 678-1157)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: code question xen/arch/x86/vmx.c
2005-08-11 21:48 code question xen/arch/x86/vmx.c Jerone Young
@ 2005-08-11 21:47 ` Keir Fraser
2005-08-11 21:57 ` Jerone Young
0 siblings, 1 reply; 3+ messages in thread
From: Keir Fraser @ 2005-08-11 21:47 UTC (permalink / raw)
To: Jerone Young; +Cc: xen-devel
On 11 Aug 2005, at 22:48, Jerone Young wrote:
> In function vmx_dr_access in xen/arch/x86/vmx.c there is a long pointer
> named "reg_p". reg_p is assigned to
>
> v->arch.guest_context.debugreg[reg] = *reg_p;
>
> in the switch case TYPE_MOV_TO_DR.
>
> yet it has no assignment before this? What is the intent of reg_p?
>
> It also is assigned in the switch case TYPE_MOVE_FROM_DR...yet it's not
> used for anything ?
It's assigned to in the macro CASE_GET_REG_P.
-- Keir
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: code question xen/arch/x86/vmx.c
2005-08-11 21:47 ` Keir Fraser
@ 2005-08-11 21:57 ` Jerone Young
0 siblings, 0 replies; 3+ messages in thread
From: Jerone Young @ 2005-08-11 21:57 UTC (permalink / raw)
To: Keir Fraser; +Cc: xen-devel
On Thu, 2005-08-11 at 22:47 +0100, Keir Fraser wrote:
> On 11 Aug 2005, at 22:48, Jerone Young wrote:
>
> > In function vmx_dr_access in xen/arch/x86/vmx.c there is a long pointer
> > named "reg_p". reg_p is assigned to
> >
> > v->arch.guest_context.debugreg[reg] = *reg_p;
> >
> > in the switch case TYPE_MOV_TO_DR.
> >
> > yet it has no assignment before this? What is the intent of reg_p?
> >
> > It also is assigned in the switch case TYPE_MOVE_FROM_DR...yet it's not
> > used for anything ?
>
> It's assigned to in the macro CASE_GET_REG_P.
doh! it's sitting right above the function :-)
>
> -- Keir
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
--
Jerone Young
IBM Linux Technology Center
jyoung5@us.ibm.com
512-838-1157 (T/L: 678-1157)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-08-11 21:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-11 21:48 code question xen/arch/x86/vmx.c Jerone Young
2005-08-11 21:47 ` Keir Fraser
2005-08-11 21:57 ` Jerone Young
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.