From: Rusty Russell <rusty@rustcorp.com.au>
To: Xiaofeng Ling <xiaofeng.ling@intel.com>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>,
xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] get xenstore buffer in vmx guest
Date: Mon, 05 Sep 2005 21:14:53 +1000 [thread overview]
Message-ID: <1125918893.6348.4.camel@localhost.localdomain> (raw)
In-Reply-To: <431C03FC.1060302@intel.com>
On Mon, 2005-09-05 at 16:38 +0800, Xiaofeng Ling wrote:
> static inline struct ringbuf_head *outbuf(void)
> {
> - return mfn_to_virt(xen_start_info.store_mfn);
> + return XENSTORE_BUF;
> }
Just a minor thing: I'd really prefer an inline function called
xenstore_page_virt() or something, rather than a macro which looks like
a constant.
Thanks!
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
next prev parent reply other threads:[~2005-09-05 11:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-05 8:38 [PATCH] get xenstore buffer in vmx guest Xiaofeng Ling
2005-09-05 11:14 ` Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-09-05 14:22 Ling, Xiaofeng
2005-09-06 0:15 ` Rusty Russell
2005-09-06 5:29 ` Xiaofeng Ling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125918893.6348.4.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=m+Ian.Pratt@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
--cc=xiaofeng.ling@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.