All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiaofeng Ling <xiaofeng.ling@intel.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>,
	xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] get xenstore buffer in vmx guest
Date: Tue, 06 Sep 2005 13:29:29 +0800	[thread overview]
Message-ID: <431D2939.1000607@intel.com> (raw)
In-Reply-To: <1125965755.7643.35.camel@localhost.localdomain>

Rusty Russell wrote:
> On Mon, 2005-09-05 at 22:22 +0800, Ling, Xiaofeng wrote:
> 
>>Rusty Russell <mailto:rusty@rustcorp.com.au> wrote:
>>+#ifdef CONFIG_XEN
>>+static inline void *xenstore_page_virt(void)
>>+{
>>+    return (void*)mfn_to_virt(xen_start_info.store_mfn);
>>+}
> 
> 
> Great!   I think the (void*) cast is redundant though?
yes

> 
>>-postcore_initcall(xenbus_probe_init);
>>+module_init(xenbus_probe_init);
>>+MODULE_LICENSE("GPL");
> 
> 
> This should probably be:
> 	MODULE_LICENSE("Dual BSD/GPL");
ok.

  reply	other threads:[~2005-09-06  5:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-05 14:22 [PATCH] get xenstore buffer in vmx guest Ling, Xiaofeng
2005-09-06  0:15 ` Rusty Russell
2005-09-06  5:29   ` Xiaofeng Ling [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-09-05  8:38 Xiaofeng Ling
2005-09-05 11:14 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=431D2939.1000607@intel.com \
    --to=xiaofeng.ling@intel.com \
    --cc=m+Ian.Pratt@cl.cam.ac.uk \
    --cc=rusty@rustcorp.com.au \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.