All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dont retry on SG_IO tape commands
@ 2005-09-18 19:53 Mike Christie
  2005-09-18 20:46 ` Mike Christie
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Christie @ 2005-09-18 19:53 UTC (permalink / raw)
  To: axboe, Kai Makisara, linux-scsi

sd does not allow scsi_io_completion to retry commands for
SG_IO requests, and it make sense that it should not happen for st
SG_IO commands too. This patch returns to the block layer that
the whole command completed and relies on the caller to check
the request errors field.

Patch was made against scsi-rc-fixes.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>

diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -4187,7 +4187,7 @@ static void scsi_tape_release(struct kre
 
 static void st_intr(struct scsi_cmnd *SCpnt)
 {
-	scsi_io_completion(SCpnt, (SCpnt->result ? 0: SCpnt->bufflen), 1);
+	scsi_io_completion(SCpnt, SCpnt->bufflen, 0);
 }
 
 /*



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dont retry on SG_IO tape commands
  2005-09-18 19:53 [PATCH] dont retry on SG_IO tape commands Mike Christie
@ 2005-09-18 20:46 ` Mike Christie
  0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2005-09-18 20:46 UTC (permalink / raw)
  To: axboe, Kai Makisara, linux-scsi

Actually forget this patch. We can just make scsi-ml handle this.


Mike Christie wrote:
> sd does not allow scsi_io_completion to retry commands for
> SG_IO requests, and it make sense that it should not happen for st
> SG_IO commands too. This patch returns to the block layer that
> the whole command completed and relies on the caller to check
> the request errors field.
> 
> Patch was made against scsi-rc-fixes.
> 
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> 
> diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
> --- a/drivers/scsi/st.c
> +++ b/drivers/scsi/st.c
> @@ -4187,7 +4187,7 @@ static void scsi_tape_release(struct kre
>  
>  static void st_intr(struct scsi_cmnd *SCpnt)
>  {
> -	scsi_io_completion(SCpnt, (SCpnt->result ? 0: SCpnt->bufflen), 1);
> +	scsi_io_completion(SCpnt, SCpnt->bufflen, 0);
>  }
>  
>  /*
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-09-18 22:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-18 19:53 [PATCH] dont retry on SG_IO tape commands Mike Christie
2005-09-18 20:46 ` Mike Christie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.