From: Arnd Bergmann <arnd@arndb.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hoan Tran <hotran@apm.com>, Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Rob Herring <robh+dt@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
Duc Dang <dhdang@apm.com>,
lho@apm.com, linux-hwmon@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver
Date: Fri, 09 Sep 2016 17:38:15 +0200 [thread overview]
Message-ID: <11301286.5CCaiCKzda@wuerfel> (raw)
In-Reply-To: <20160907223705.GA31582@roeck-us.net>
On Wednesday, September 7, 2016 3:37:05 PM CEST Guenter Roeck wrote:
> On Wed, Sep 07, 2016 at 11:41:44PM +0200, Arnd Bergmann wrote:
> > On Thursday, July 21, 2016 1:55:56 PM CEST Hoan Tran wrote:
> > > + ctx->comm_base_addr = cppc_ss->base_address;
> > > + if (ctx->comm_base_addr) {
> > > + ctx->pcc_comm_addr =
> > > + acpi_os_ioremap(ctx->comm_base_addr,
> > > + cppc_ss->length);
> > >
> >
> > This causes the arm64 allmodconfig build to fail now, according to
> > kernelci:
> >
> > 1 ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined!
> >
> > Should this perhaps call ioremap() or memremap() instead?
> >
> Hmmm ... almost sounds to me like blaming the messenger. e7cd190385d1 ("arm64:
> mark reserved memblock regions explicitly in iomem") starts using a function
> in acpi_os_ioremap() which is not exported. On top of that, memblock_is_memory()
> is declared as __init_memblock, which makes me really uncomfortable.
> If acpi_os_ioremap() must not be used by modules, and possibly only during
> early (?) initialization, maybe its declaration should state those limitations ?
I think there is more wrong with it, the driver also accesses a shared
memory area with kernel pointers using readl_relaxed/writel_relaxed,
which are only valid on MMIO registers.
I've prepared a patch, please have a look at the follow-up email.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver
Date: Fri, 09 Sep 2016 17:38:15 +0200 [thread overview]
Message-ID: <11301286.5CCaiCKzda@wuerfel> (raw)
In-Reply-To: <20160907223705.GA31582@roeck-us.net>
On Wednesday, September 7, 2016 3:37:05 PM CEST Guenter Roeck wrote:
> On Wed, Sep 07, 2016 at 11:41:44PM +0200, Arnd Bergmann wrote:
> > On Thursday, July 21, 2016 1:55:56 PM CEST Hoan Tran wrote:
> > > + ctx->comm_base_addr = cppc_ss->base_address;
> > > + if (ctx->comm_base_addr) {
> > > + ctx->pcc_comm_addr =
> > > + acpi_os_ioremap(ctx->comm_base_addr,
> > > + cppc_ss->length);
> > >
> >
> > This causes the arm64 allmodconfig build to fail now, according to
> > kernelci:
> >
> > 1 ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined!
> >
> > Should this perhaps call ioremap() or memremap() instead?
> >
> Hmmm ... almost sounds to me like blaming the messenger. e7cd190385d1 ("arm64:
> mark reserved memblock regions explicitly in iomem") starts using a function
> in acpi_os_ioremap() which is not exported. On top of that, memblock_is_memory()
> is declared as __init_memblock, which makes me really uncomfortable.
> If acpi_os_ioremap() must not be used by modules, and possibly only during
> early (?) initialization, maybe its declaration should state those limitations ?
I think there is more wrong with it, the driver also accesses a shared
memory area with kernel pointers using readl_relaxed/writel_relaxed,
which are only valid on MMIO registers.
I've prepared a patch, please have a look at the follow-up email.
Arnd
next prev parent reply other threads:[~2016-09-09 15:38 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 20:55 [PATCH v3 0/3] hwmon: xgene: Add support for X-Gene hwmon driver Hoan Tran
2016-07-21 20:55 ` Hoan Tran
2016-07-21 20:55 ` [PATCH v3 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation Hoan Tran
2016-07-21 20:55 ` Hoan Tran
2016-07-21 22:02 ` Guenter Roeck
2016-07-21 22:02 ` Guenter Roeck
2016-07-21 20:55 ` [PATCH v3 2/3] hwmon: xgene: Add hwmon driver Hoan Tran
2016-07-21 20:55 ` Hoan Tran
2016-07-21 22:09 ` Guenter Roeck
2016-07-21 22:09 ` Guenter Roeck
2016-07-21 22:21 ` Hoan Tran
2016-07-21 22:21 ` Hoan Tran
2016-08-01 13:21 ` kbuild test robot
2016-08-01 13:21 ` kbuild test robot
2016-08-01 13:21 ` kbuild test robot
2016-08-01 16:39 ` Hoan Tran
2016-08-01 16:39 ` Hoan Tran
2016-08-01 16:39 ` Hoan Tran
2016-09-07 21:41 ` Arnd Bergmann
2016-09-07 21:41 ` Arnd Bergmann
2016-09-07 21:41 ` Arnd Bergmann
2016-09-07 22:27 ` Guenter Roeck
2016-09-07 22:27 ` Guenter Roeck
2016-09-08 8:15 ` Arnd Bergmann
2016-09-08 8:15 ` Arnd Bergmann
2016-09-08 14:55 ` Guenter Roeck
2016-09-08 14:55 ` Guenter Roeck
2016-09-08 14:59 ` Arnd Bergmann
2016-09-08 14:59 ` Arnd Bergmann
2016-09-07 22:37 ` Guenter Roeck
2016-09-07 22:37 ` Guenter Roeck
2016-09-08 8:14 ` Arnd Bergmann
2016-09-08 8:14 ` Arnd Bergmann
2016-09-08 8:14 ` Arnd Bergmann
2016-09-08 10:47 ` James Morse
2016-09-08 10:47 ` James Morse
2016-09-08 10:47 ` James Morse
2016-09-09 3:18 ` AKASHI Takahiro
2016-09-09 3:18 ` AKASHI Takahiro
2016-09-09 9:31 ` James Morse
2016-09-09 9:31 ` James Morse
2016-09-09 15:38 ` Arnd Bergmann [this message]
2016-09-09 15:38 ` Arnd Bergmann
2016-09-09 15:38 ` [PATCH] hwmon: xgene: access mailbox as RAM Arnd Bergmann
2016-09-09 15:38 ` Arnd Bergmann
2016-09-09 16:58 ` Guenter Roeck
2016-09-09 16:58 ` Guenter Roeck
2016-09-09 17:05 ` Hoan Tran
2016-09-09 17:05 ` Hoan Tran
2016-09-09 17:05 ` Hoan Tran
2016-09-09 19:24 ` Hoan Tran
2016-09-09 19:24 ` Hoan Tran
2016-09-09 19:58 ` Arnd Bergmann
2016-09-09 19:58 ` Arnd Bergmann
2016-09-09 19:58 ` Arnd Bergmann
2016-09-09 20:10 ` [PATCH v2] " Arnd Bergmann
2016-09-09 20:10 ` Arnd Bergmann
2016-09-09 20:47 ` Hoan Tran
2016-09-09 20:47 ` Hoan Tran
2016-09-09 21:56 ` Guenter Roeck
2016-09-09 21:56 ` Guenter Roeck
2016-09-09 21:56 ` Guenter Roeck
2016-09-09 20:43 ` [PATCH] " Hoan Tran
2016-09-09 20:43 ` Hoan Tran
2016-09-09 20:43 ` Hoan Tran
2016-09-09 20:50 ` Arnd Bergmann
2016-09-09 20:50 ` Arnd Bergmann
2016-09-09 20:50 ` Arnd Bergmann
2016-09-09 20:51 ` Hoan Tran
2016-09-09 20:51 ` Hoan Tran
2016-07-21 20:55 ` [PATCH v3 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree Hoan Tran
2016-07-21 20:55 ` Hoan Tran
2016-07-21 22:09 ` Guenter Roeck
2016-07-21 22:09 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11301286.5CCaiCKzda@wuerfel \
--to=arnd@arndb.de \
--cc=ashwin.chaugule@linaro.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dhdang@apm.com \
--cc=hotran@apm.com \
--cc=jassisinghbrar@gmail.com \
--cc=jdelvare@suse.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.