From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Hoan Tran <hotran@apm.com>, Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Rob Herring <robh+dt@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
Duc Dang <dhdang@apm.com>, Loc Ho <lho@apm.com>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
Devicetree List <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] hwmon: xgene: access mailbox as RAM
Date: Fri, 9 Sep 2016 14:56:53 -0700 [thread overview]
Message-ID: <20160909215653.GA2362@roeck-us.net> (raw)
In-Reply-To: <3475893.910N1IvcYZ@wuerfel>
On Fri, Sep 09, 2016 at 10:10:45PM +0200, Arnd Bergmann wrote:
> The newly added hwmon driver fails to build in an allmodconfig
> kernel:
>
> ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined!
>
> According to comments in the code, the mailbox is a shared memory region,
> not a set of MMIO registers, so we should use memremap() for mapping it
> instead of ioremap or acpi_os_ioremap, and pointer dereferences instead
> of readl/writel.
>
> The driver already uses plain kernel pointers, so it's a bit unusual
> to work with functions that operate on __iomem pointers, and this
> fixes that part too.
>
> I'm using READ_ONCE/WRITE_ONCE here to keep the existing behavior
> regarding the ordering of the accesses from the CPU, but note that
> there are no barriers (also unchanged from before).
>
> I'm also keeping the endianess behavior, though I'm unsure whether
> the message data was supposed to be in LE32 format in the first
> place, it's possible this was meant to be interpreted as a byte
> stream instead.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied after 's/endianess/endianness/' to make checkpatch happy.
Thanks,
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] hwmon: xgene: access mailbox as RAM
Date: Fri, 9 Sep 2016 14:56:53 -0700 [thread overview]
Message-ID: <20160909215653.GA2362@roeck-us.net> (raw)
In-Reply-To: <3475893.910N1IvcYZ@wuerfel>
On Fri, Sep 09, 2016 at 10:10:45PM +0200, Arnd Bergmann wrote:
> The newly added hwmon driver fails to build in an allmodconfig
> kernel:
>
> ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined!
>
> According to comments in the code, the mailbox is a shared memory region,
> not a set of MMIO registers, so we should use memremap() for mapping it
> instead of ioremap or acpi_os_ioremap, and pointer dereferences instead
> of readl/writel.
>
> The driver already uses plain kernel pointers, so it's a bit unusual
> to work with functions that operate on __iomem pointers, and this
> fixes that part too.
>
> I'm using READ_ONCE/WRITE_ONCE here to keep the existing behavior
> regarding the ordering of the accesses from the CPU, but note that
> there are no barriers (also unchanged from before).
>
> I'm also keeping the endianess behavior, though I'm unsure whether
> the message data was supposed to be in LE32 format in the first
> place, it's possible this was meant to be interpreted as a byte
> stream instead.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied after 's/endianess/endianness/' to make checkpatch happy.
Thanks,
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Hoan Tran <hotran-qTEPVZfXA3Y@public.gmane.org>,
Jean Delvare <jdelvare-IBi9RG/b67k@public.gmane.org>,
Jonathan Corbet <corbet-T1hC0tSOHrs@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jassi Brar
<jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Ashwin Chaugule
<ashwin.chaugule-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Duc Dang <dhdang-qTEPVZfXA3Y@public.gmane.org>,
Loc Ho <lho-qTEPVZfXA3Y@public.gmane.org>,
linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Devicetree List
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] hwmon: xgene: access mailbox as RAM
Date: Fri, 9 Sep 2016 14:56:53 -0700 [thread overview]
Message-ID: <20160909215653.GA2362@roeck-us.net> (raw)
In-Reply-To: <3475893.910N1IvcYZ@wuerfel>
On Fri, Sep 09, 2016 at 10:10:45PM +0200, Arnd Bergmann wrote:
> The newly added hwmon driver fails to build in an allmodconfig
> kernel:
>
> ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined!
>
> According to comments in the code, the mailbox is a shared memory region,
> not a set of MMIO registers, so we should use memremap() for mapping it
> instead of ioremap or acpi_os_ioremap, and pointer dereferences instead
> of readl/writel.
>
> The driver already uses plain kernel pointers, so it's a bit unusual
> to work with functions that operate on __iomem pointers, and this
> fixes that part too.
>
> I'm using READ_ONCE/WRITE_ONCE here to keep the existing behavior
> regarding the ordering of the accesses from the CPU, but note that
> there are no barriers (also unchanged from before).
>
> I'm also keeping the endianess behavior, though I'm unsure whether
> the message data was supposed to be in LE32 format in the first
> place, it's possible this was meant to be interpreted as a byte
> stream instead.
>
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Applied after 's/endianess/endianness/' to make checkpatch happy.
Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-09 21:56 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 20:55 [PATCH v3 0/3] hwmon: xgene: Add support for X-Gene hwmon driver Hoan Tran
2016-07-21 20:55 ` Hoan Tran
2016-07-21 20:55 ` [PATCH v3 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation Hoan Tran
2016-07-21 20:55 ` Hoan Tran
2016-07-21 22:02 ` Guenter Roeck
2016-07-21 22:02 ` Guenter Roeck
2016-07-21 20:55 ` [PATCH v3 2/3] hwmon: xgene: Add hwmon driver Hoan Tran
2016-07-21 20:55 ` Hoan Tran
2016-07-21 22:09 ` Guenter Roeck
2016-07-21 22:09 ` Guenter Roeck
2016-07-21 22:21 ` Hoan Tran
2016-07-21 22:21 ` Hoan Tran
2016-08-01 13:21 ` kbuild test robot
2016-08-01 13:21 ` kbuild test robot
2016-08-01 13:21 ` kbuild test robot
2016-08-01 16:39 ` Hoan Tran
2016-08-01 16:39 ` Hoan Tran
2016-08-01 16:39 ` Hoan Tran
2016-09-07 21:41 ` Arnd Bergmann
2016-09-07 21:41 ` Arnd Bergmann
2016-09-07 21:41 ` Arnd Bergmann
2016-09-07 22:27 ` Guenter Roeck
2016-09-07 22:27 ` Guenter Roeck
2016-09-08 8:15 ` Arnd Bergmann
2016-09-08 8:15 ` Arnd Bergmann
2016-09-08 14:55 ` Guenter Roeck
2016-09-08 14:55 ` Guenter Roeck
2016-09-08 14:59 ` Arnd Bergmann
2016-09-08 14:59 ` Arnd Bergmann
2016-09-07 22:37 ` Guenter Roeck
2016-09-07 22:37 ` Guenter Roeck
2016-09-08 8:14 ` Arnd Bergmann
2016-09-08 8:14 ` Arnd Bergmann
2016-09-08 8:14 ` Arnd Bergmann
2016-09-08 10:47 ` James Morse
2016-09-08 10:47 ` James Morse
2016-09-08 10:47 ` James Morse
2016-09-09 3:18 ` AKASHI Takahiro
2016-09-09 3:18 ` AKASHI Takahiro
2016-09-09 9:31 ` James Morse
2016-09-09 9:31 ` James Morse
2016-09-09 15:38 ` Arnd Bergmann
2016-09-09 15:38 ` Arnd Bergmann
2016-09-09 15:38 ` [PATCH] hwmon: xgene: access mailbox as RAM Arnd Bergmann
2016-09-09 15:38 ` Arnd Bergmann
2016-09-09 16:58 ` Guenter Roeck
2016-09-09 16:58 ` Guenter Roeck
2016-09-09 17:05 ` Hoan Tran
2016-09-09 17:05 ` Hoan Tran
2016-09-09 17:05 ` Hoan Tran
2016-09-09 19:24 ` Hoan Tran
2016-09-09 19:24 ` Hoan Tran
2016-09-09 19:58 ` Arnd Bergmann
2016-09-09 19:58 ` Arnd Bergmann
2016-09-09 19:58 ` Arnd Bergmann
2016-09-09 20:10 ` [PATCH v2] " Arnd Bergmann
2016-09-09 20:10 ` Arnd Bergmann
2016-09-09 20:47 ` Hoan Tran
2016-09-09 20:47 ` Hoan Tran
2016-09-09 21:56 ` Guenter Roeck [this message]
2016-09-09 21:56 ` Guenter Roeck
2016-09-09 21:56 ` Guenter Roeck
2016-09-09 20:43 ` [PATCH] " Hoan Tran
2016-09-09 20:43 ` Hoan Tran
2016-09-09 20:43 ` Hoan Tran
2016-09-09 20:50 ` Arnd Bergmann
2016-09-09 20:50 ` Arnd Bergmann
2016-09-09 20:50 ` Arnd Bergmann
2016-09-09 20:51 ` Hoan Tran
2016-09-09 20:51 ` Hoan Tran
2016-07-21 20:55 ` [PATCH v3 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree Hoan Tran
2016-07-21 20:55 ` Hoan Tran
2016-07-21 22:09 ` Guenter Roeck
2016-07-21 22:09 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909215653.GA2362@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=ashwin.chaugule@linaro.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dhdang@apm.com \
--cc=hotran@apm.com \
--cc=jassisinghbrar@gmail.com \
--cc=jdelvare@suse.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.