From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Paul Jackson <pj@sgi.com>
Cc: christoph@lameter.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, manfred@colorfullife.com
Subject: Re: [RFT/PATCH] slab: consolidate allocation paths
Date: Sun, 05 Feb 2006 11:18:29 +0200 [thread overview]
Message-ID: <1139131109.11782.8.camel@localhost> (raw)
In-Reply-To: <1139128872.11782.5.camel@localhost>
On Sun, 2006-02-05 at 10:41 +0200, Pekka Enberg wrote:
> Ah, sorry about that, I forgot to verify the NUMA case. The problem is
> that to kmalloc_node() is calling cache_alloc() now which is forced
> inline. I am wondering, would it be ok to make __cache_alloc()
> non-inline for NUMA? The relevant numbers are:
[snip]
Btw, we can also change kmalloc_node() to use kmem_cache_alloc_node()
again but for that, we have a minor correctness issue, namely, the
__builtin_return_address(0) won't work for kmalloc_node(). Hmm.
Pekka
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Paul Jackson <pj@sgi.com>
Cc: christoph@lameter.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, manfred@colorfullife.com
Subject: Re: [RFT/PATCH] slab: consolidate allocation paths
Date: Sun, 05 Feb 2006 11:18:29 +0200 [thread overview]
Message-ID: <1139131109.11782.8.camel@localhost> (raw)
In-Reply-To: <1139128872.11782.5.camel@localhost>
On Sun, 2006-02-05 at 10:41 +0200, Pekka Enberg wrote:
> Ah, sorry about that, I forgot to verify the NUMA case. The problem is
> that to kmalloc_node() is calling cache_alloc() now which is forced
> inline. I am wondering, would it be ok to make __cache_alloc()
> non-inline for NUMA? The relevant numbers are:
[snip]
Btw, we can also change kmalloc_node() to use kmem_cache_alloc_node()
again but for that, we have a minor correctness issue, namely, the
__builtin_return_address(0) won't work for kmalloc_node(). Hmm.
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-02-05 9:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-04 13:33 [RFT/PATCH] slab: consolidate allocation paths Pekka Enberg
2006-02-04 13:33 ` Pekka Enberg
2006-02-04 15:11 ` Christoph Lameter
2006-02-04 15:11 ` Christoph Lameter
2006-02-04 16:26 ` Pekka Enberg
2006-02-04 16:26 ` Pekka Enberg
2006-02-04 16:32 ` Pekka Enberg
2006-02-04 16:32 ` Pekka Enberg
2006-02-05 2:00 ` Paul Jackson
2006-02-05 2:00 ` Paul Jackson
2006-02-05 3:44 ` Christoph Lameter
2006-02-05 3:44 ` Christoph Lameter
2006-02-05 4:36 ` Paul Jackson
2006-02-05 4:36 ` Paul Jackson
2006-02-05 8:41 ` Pekka Enberg
2006-02-05 8:41 ` Pekka Enberg
2006-02-05 9:18 ` Pekka Enberg [this message]
2006-02-05 9:18 ` Pekka Enberg
2006-02-05 12:29 ` Pekka Enberg
2006-02-05 12:29 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1139131109.11782.8.camel@localhost \
--to=penberg@cs.helsinki.fi \
--cc=christoph@lameter.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manfred@colorfullife.com \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.