All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	Marek Szyprowski
	<m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCHv3 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer
Date: Sun, 10 Nov 2013 19:15:21 +0100	[thread overview]
Message-ID: <11439632.EJeOOmBkrd@flatron> (raw)
In-Reply-To: <1383530161-24080-3-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Hi Chanwoo, Marek,

On Monday 04 of November 2013 10:56:00 Chanwoo Choi wrote:
> From: Marek Szyprowski <m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> 

No patch description?

> Signed-off-by: Marek Szyprowski <m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  arch/arm/boot/dts/exynos4212.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
> index 3081bae..d7a3fbc 100644
> --- a/arch/arm/boot/dts/exynos4212.dtsi
> +++ b/arch/arm/boot/dts/exynos4212.dtsi
> @@ -43,6 +43,8 @@
>  		interrupt-parent = <&mct_map>;
>  		interrupts = <0 0>, <1 0>, <2 0>, <3 0>,
>  			     <4 0>, <5 0>;
> +		clocks = <&clock 3>, <&clock 344>;
> +		clock-names = "fin_pll", "mct";
>  
>  		mct_map: mct-map {
>  			#interrupt-cells = <2>;
> 

Otherwise the patch is technically correct, but I have already sent
a series[1] that moves MCT node one level up to exynos4x12.dtsi, which
also solves this problem.

[1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/22207/focus=22208

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer
Date: Sun, 10 Nov 2013 19:15:21 +0100	[thread overview]
Message-ID: <11439632.EJeOOmBkrd@flatron> (raw)
In-Reply-To: <1383530161-24080-3-git-send-email-cw00.choi@samsung.com>

Hi Chanwoo, Marek,

On Monday 04 of November 2013 10:56:00 Chanwoo Choi wrote:
> From: Marek Szyprowski <m.szyprowski@samsung.com>
> 

No patch description?

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4212.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
> index 3081bae..d7a3fbc 100644
> --- a/arch/arm/boot/dts/exynos4212.dtsi
> +++ b/arch/arm/boot/dts/exynos4212.dtsi
> @@ -43,6 +43,8 @@
>  		interrupt-parent = <&mct_map>;
>  		interrupts = <0 0>, <1 0>, <2 0>, <3 0>,
>  			     <4 0>, <5 0>;
> +		clocks = <&clock 3>, <&clock 344>;
> +		clock-names = "fin_pll", "mct";
>  
>  		mct_map: mct-map {
>  			#interrupt-cells = <2>;
> 

Otherwise the patch is technically correct, but I have already sent
a series[1] that moves MCT node one level up to exynos4x12.dtsi, which
also solves this problem.

[1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/22207/focus=22208

Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: kgene.kim@samsung.com, t.figa@samsung.com,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, kyungmin.park@samsung.com,
	rob.herring@calxeda.com, pawel.moll@arm.com,
	mark.rutland@arm.com, swarren@wwwdotorg.org,
	ijc+devicetree@hellion.org.uk, linux@arm.linux.org.uk,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCHv3 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer
Date: Sun, 10 Nov 2013 19:15:21 +0100	[thread overview]
Message-ID: <11439632.EJeOOmBkrd@flatron> (raw)
In-Reply-To: <1383530161-24080-3-git-send-email-cw00.choi@samsung.com>

Hi Chanwoo, Marek,

On Monday 04 of November 2013 10:56:00 Chanwoo Choi wrote:
> From: Marek Szyprowski <m.szyprowski@samsung.com>
> 

No patch description?

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4212.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
> index 3081bae..d7a3fbc 100644
> --- a/arch/arm/boot/dts/exynos4212.dtsi
> +++ b/arch/arm/boot/dts/exynos4212.dtsi
> @@ -43,6 +43,8 @@
>  		interrupt-parent = <&mct_map>;
>  		interrupts = <0 0>, <1 0>, <2 0>, <3 0>,
>  			     <4 0>, <5 0>;
> +		clocks = <&clock 3>, <&clock 344>;
> +		clock-names = "fin_pll", "mct";
>  
>  		mct_map: mct-map {
>  			#interrupt-cells = <2>;
> 

Otherwise the patch is technically correct, but I have already sent
a series[1] that moves MCT node one level up to exynos4x12.dtsi, which
also solves this problem.

[1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/22207/focus=22208

Best regards,
Tomasz


  parent reply	other threads:[~2013-11-10 18:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04  1:55 [PATCHv3 0/3] ARM: dts: exynos: Add missing dt data to bring up kernel featurea Chanwoo Choi
2013-11-04  1:55 ` Chanwoo Choi
2013-11-04  1:55 ` [PATCHv3 1/3] ARM: dts: exynos4212: Add PMU dt data for pmu-irq Chanwoo Choi
2013-11-04  1:55   ` Chanwoo Choi
2013-11-10 18:12   ` Tomasz Figa
2013-11-10 18:12     ` Tomasz Figa
2013-11-04  1:56 ` [PATCHv3 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer Chanwoo Choi
2013-11-04  1:56   ` Chanwoo Choi
     [not found]   ` <1383530161-24080-3-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-11-10 18:15     ` Tomasz Figa [this message]
2013-11-10 18:15       ` Tomasz Figa
2013-11-10 18:15       ` Tomasz Figa
2013-11-04  1:56 ` [PATCHv3 3/3] ARM: dts: exynos4x12: Add gps_alive power domain for exynos4x12 Chanwoo Choi
2013-11-04  1:56   ` Chanwoo Choi
2013-11-10 18:16   ` Tomasz Figa
2013-11-10 18:16     ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11439632.EJeOOmBkrd@flatron \
    --to=tomasz.figa-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.