From: Tomasz Figa <tomasz.figa@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
kgene.kim@samsung.com, t.figa@samsung.com, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux@arm.linux.org.uk, pawel.moll@arm.com,
swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
kyungmin.park@samsung.com
Subject: Re: [PATCHv3 3/3] ARM: dts: exynos4x12: Add gps_alive power domain for exynos4x12
Date: Sun, 10 Nov 2013 19:16:31 +0100 [thread overview]
Message-ID: <4207742.ampVWzpqgB@flatron> (raw)
In-Reply-To: <1383530161-24080-4-git-send-email-cw00.choi@samsung.com>
Hi Chanwoo,
On Monday 04 of November 2013 10:56:01 Chanwoo Choi wrote:
> This patch gps_alive power domain to exynos4x12.dtsi.
Patch description lacks rationale behind the change.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index ad531fe..3f5b416 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -35,6 +35,11 @@
> reg = <0x10023CA0 0x20>;
> };
>
> + pd_gps_alive: gps-alive-power-domain@10023D00 {
> + compatible = "samsung,exynos4210-pd";
> + reg = <0x10023D00 0x20>;
> + };
> +
> clock: clock-controller@10030000 {
> compatible = "samsung,exynos4412-clock";
> reg = <0x10030000 0x20000>;
>
Otherwise the patch looks good.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 3/3] ARM: dts: exynos4x12: Add gps_alive power domain for exynos4x12
Date: Sun, 10 Nov 2013 19:16:31 +0100 [thread overview]
Message-ID: <4207742.ampVWzpqgB@flatron> (raw)
In-Reply-To: <1383530161-24080-4-git-send-email-cw00.choi@samsung.com>
Hi Chanwoo,
On Monday 04 of November 2013 10:56:01 Chanwoo Choi wrote:
> This patch gps_alive power domain to exynos4x12.dtsi.
Patch description lacks rationale behind the change.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index ad531fe..3f5b416 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -35,6 +35,11 @@
> reg = <0x10023CA0 0x20>;
> };
>
> + pd_gps_alive: gps-alive-power-domain at 10023D00 {
> + compatible = "samsung,exynos4210-pd";
> + reg = <0x10023D00 0x20>;
> + };
> +
> clock: clock-controller at 10030000 {
> compatible = "samsung,exynos4412-clock";
> reg = <0x10030000 0x20000>;
>
Otherwise the patch looks good.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-11-10 18:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 1:55 [PATCHv3 0/3] ARM: dts: exynos: Add missing dt data to bring up kernel featurea Chanwoo Choi
2013-11-04 1:55 ` Chanwoo Choi
2013-11-04 1:55 ` [PATCHv3 1/3] ARM: dts: exynos4212: Add PMU dt data for pmu-irq Chanwoo Choi
2013-11-04 1:55 ` Chanwoo Choi
2013-11-10 18:12 ` Tomasz Figa
2013-11-10 18:12 ` Tomasz Figa
2013-11-04 1:56 ` [PATCHv3 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer Chanwoo Choi
2013-11-04 1:56 ` Chanwoo Choi
[not found] ` <1383530161-24080-3-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-11-10 18:15 ` Tomasz Figa
2013-11-10 18:15 ` Tomasz Figa
2013-11-10 18:15 ` Tomasz Figa
2013-11-04 1:56 ` [PATCHv3 3/3] ARM: dts: exynos4x12: Add gps_alive power domain for exynos4x12 Chanwoo Choi
2013-11-04 1:56 ` Chanwoo Choi
2013-11-10 18:16 ` Tomasz Figa [this message]
2013-11-10 18:16 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4207742.ampVWzpqgB@flatron \
--to=tomasz.figa@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.