From: "Michael Chan" <mchan@broadcom.com>
To: "Herbert Xu" <herbert@gondor.apana.org.au>
Cc: shawvrana@gmail.com, netdev@vger.kernel.org,
"Auke Kok" <auke-jan.h.kok@intel.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: e1000_down and tx_timeout worker race cleaning the transmit buffers
Date: Thu, 20 Apr 2006 17:10:13 -0700 [thread overview]
Message-ID: <1145578214.3195.6.camel@rh4> (raw)
In-Reply-To: <20060421013340.GA29123@gondor.apana.org.au>
On Fri, 2006-04-21 at 11:33 +1000, Herbert Xu wrote:
> Actually, what if the tg3_close is followed by a tg3_open? That could
> produce a spurious reset which I suppose isn't that bad.
Yes, an extra reset. And yes, it isn't too bad.
> Also if the
> module is unloaded bad things will happen as well.
In tg3_remove_one(), we call flush_scheduled_work() in case the
reset_task is still pending. Here, it is safe to call
flush_scheduled_work() because we're not holding the rtnl. Again, when
it runs, nothing bad will happen because it will see netif_running() ==
0.
next prev parent reply other threads:[~2006-04-21 1:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200604201035.00100.shaw@vranix.com>
2006-04-20 23:36 ` e1000_down and tx_timeout worker race cleaning the transmit buffers Herbert Xu
2006-04-20 23:51 ` Herbert Xu
2006-04-20 22:36 ` Michael Chan
2006-04-21 1:27 ` Herbert Xu
2006-04-21 1:33 ` Herbert Xu
2006-04-21 0:10 ` Michael Chan [this message]
2006-04-21 2:37 ` Herbert Xu
2006-04-21 2:40 ` Herbert Xu
2006-04-21 1:24 ` Michael Chan
2006-04-21 13:27 ` Andy Gospodarek
2006-04-21 15:28 ` Michael Chan
2006-04-21 20:01 ` Andy Gospodarek
2006-04-21 19:00 ` Michael Chan
2006-04-21 20:46 ` Andy Gospodarek
2006-04-27 0:14 ` Shaw
2006-04-27 4:55 ` Auke Kok
2006-04-29 21:57 ` Shaw Vrana
2006-04-21 2:42 ` Shaw Vrana
2006-04-21 1:33 ` Michael Chan
2006-04-21 3:05 ` shaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145578214.3195.6.camel@rh4 \
--to=mchan@broadcom.com \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=shawvrana@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.