From: "Michael Chan" <mchan@broadcom.com>
To: "Shaw Vrana" <shawvrana@gmail.com>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, "Auke Kok" <auke-jan.h.kok@intel.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: e1000_down and tx_timeout worker race cleaning the transmit buffers
Date: Thu, 20 Apr 2006 18:33:28 -0700 [thread overview]
Message-ID: <1145583208.3195.22.camel@rh4> (raw)
In-Reply-To: <200604201942.07009.shawvrana@acm.org>
On Thu, 2006-04-20 at 19:42 -0700, Shaw Vrana wrote:
> I'll bite! Here's a patch to add a call to flush_scheduled_work() in
> e1000_down. It's against 2.6.16.9.
>
You're not following our discussion. It is not safe to call
flush_scheduled_work() in a driver's close() because it is holding the
rtnl and can deadlock with linkwatch_event() if it happens to be on the
workqueue.
next prev parent reply other threads:[~2006-04-21 3:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200604201035.00100.shaw@vranix.com>
2006-04-20 23:36 ` e1000_down and tx_timeout worker race cleaning the transmit buffers Herbert Xu
2006-04-20 23:51 ` Herbert Xu
2006-04-20 22:36 ` Michael Chan
2006-04-21 1:27 ` Herbert Xu
2006-04-21 1:33 ` Herbert Xu
2006-04-21 0:10 ` Michael Chan
2006-04-21 2:37 ` Herbert Xu
2006-04-21 2:40 ` Herbert Xu
2006-04-21 1:24 ` Michael Chan
2006-04-21 13:27 ` Andy Gospodarek
2006-04-21 15:28 ` Michael Chan
2006-04-21 20:01 ` Andy Gospodarek
2006-04-21 19:00 ` Michael Chan
2006-04-21 20:46 ` Andy Gospodarek
2006-04-27 0:14 ` Shaw
2006-04-27 4:55 ` Auke Kok
2006-04-29 21:57 ` Shaw Vrana
2006-04-21 2:42 ` Shaw Vrana
2006-04-21 1:33 ` Michael Chan [this message]
2006-04-21 3:05 ` shaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145583208.3195.22.camel@rh4 \
--to=mchan@broadcom.com \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=shawvrana@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.