All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: john stultz <johnstul@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	Paul Mackerras <paulus@samba.org>,
	mingo@elte.hu, tglx@linutronix.de
Subject: Re: [RFC PATCH 1/4] powerpc 2.6.16-rt17: to build on powerpc w/ RT
Date: Thu, 17 Aug 2006 06:43:21 +0200	[thread overview]
Message-ID: <1155789801.11312.152.camel@localhost.localdomain> (raw)
In-Reply-To: <1155776171.15360.22.camel@localhost.localdomain>


> > Well, I've been wanting to look at your stuff and possibly do the
> > conversion for some time, provided we don't lose performances ... Our
> > current implementation is very optimized to avoid even memory barriers
> > in most cases and I doubt we'll be able to be as fine tuned using your
> > generic code, thus it's a tradeoff decision that we have to do. But
> > then, I need to look into the details before doing any final
> > statement :)
> 
> Ok, although do let me know if you see places where the generic code
> could use any of the optimizations used in powerpc.

Difficult... but maybe. One of the main idea is that the 3 values used
for "calibration" (pre-mult offset, multiplier and post-mult offset) are
in a structure. There is an array of 2 of these and a pointer to the
"current" one. When changing those values, we update the "other" one,
wmb, then flip the pointer. The readers can then mostly be barrier-less
since there is a natural data dependency on the pointer.

Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: john stultz <johnstul@us.ibm.com>
Cc: Tsutomu OWA <tsutomu.owa@toshiba.co.jp>,
	linuxppc-dev@ozlabs.org, mingo@elte.hu,
	Paul Mackerras <paulus@samba.org>,
	linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [RFC PATCH 1/4] powerpc 2.6.16-rt17: to build on powerpc w/ RT
Date: Thu, 17 Aug 2006 06:43:21 +0200	[thread overview]
Message-ID: <1155789801.11312.152.camel@localhost.localdomain> (raw)
In-Reply-To: <1155776171.15360.22.camel@localhost.localdomain>


> > Well, I've been wanting to look at your stuff and possibly do the
> > conversion for some time, provided we don't lose performances ... Our
> > current implementation is very optimized to avoid even memory barriers
> > in most cases and I doubt we'll be able to be as fine tuned using your
> > generic code, thus it's a tradeoff decision that we have to do. But
> > then, I need to look into the details before doing any final
> > statement :)
> 
> Ok, although do let me know if you see places where the generic code
> could use any of the optimizations used in powerpc.

Difficult... but maybe. One of the main idea is that the 3 values used
for "calibration" (pre-mult offset, multiplier and post-mult offset) are
in a structure. There is an array of 2 of these and a pointer to the
"current" one. When changing those values, we update the "other" one,
wmb, then flip the pointer. The readers can then mostly be barrier-less
since there is a natural data dependency on the pointer.

Ben.



  reply	other threads:[~2006-08-17  4:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-11  2:01 [RFC PATCH 1/4] powerpc 2.6.16-rt17: to build on powerpc w/ RT Tsutomu OWA
2006-08-11  2:01 ` Tsutomu OWA
2006-08-11  5:11 ` Paul Mackerras
2006-08-11  5:11   ` Paul Mackerras
2006-08-11  6:08   ` Tsutomu OWA
2006-08-11  6:08     ` Tsutomu OWA
2006-08-11 17:56     ` john stultz
2006-08-11 17:56       ` john stultz
2006-08-16 23:38       ` Benjamin Herrenschmidt
2006-08-16 23:38         ` Benjamin Herrenschmidt
2006-08-17  0:00         ` john stultz
2006-08-17  0:00           ` john stultz
2006-08-17  0:26           ` Benjamin Herrenschmidt
2006-08-17  0:26             ` Benjamin Herrenschmidt
2006-08-17  0:56             ` john stultz
2006-08-17  0:56               ` john stultz
2006-08-17  4:43               ` Benjamin Herrenschmidt [this message]
2006-08-17  4:43                 ` Benjamin Herrenschmidt
2006-08-21 10:01       ` Tsutomu OWA
2006-08-21 10:01         ` Tsutomu OWA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1155789801.11312.152.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.