connectathon special test failure in recent kernels

connectathon special test failure in recent kernels

[Chuck Lever]

Is the connectathon holey test failure going to be fixed before 2.6.18
is finalized?

This is from a 2.6.18-rc3 client:

test exclusive create.

test negative seek, you should get: read: Invalid argument
or lseek: Invalid argument
lseek: Invalid argument

test rename

test truncate
truncate succeeded

test holey file support
read (hole) offset 8192, sz = 56667, bytes = 5141 (ret -1), holesz = 9012
read: Input/output error
special tests failed
Tests failed, leaving /mnt/brahms mounted
[cel@picasso cthon04]$

-- 
"We who cut mere stones must always be envisioning cathedrals"
   -- Quarry worker's creed

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: connectathon special test failure in recent kernels

[Trond Myklebust]

On Tue, 2006-08-08 at 15:20 -0400, Chuck Lever wrote:
> Is the connectathon holey test failure going to be fixed before 2.6.18
> is finalized?

Depends. Have you traced it in order to figure out what is wrong?

Cheers,
  Trond

> This is from a 2.6.18-rc3 client:
> 
> test exclusive create.
> 
> test negative seek, you should get: read: Invalid argument
> or lseek: Invalid argument
> lseek: Invalid argument
> 
> test rename
> 
> test truncate
> truncate succeeded
> 
> test holey file support
> read (hole) offset 8192, sz = 56667, bytes = 5141 (ret -1), holesz = 9012
> read: Input/output error
> special tests failed
> Tests failed, leaving /mnt/brahms mounted
> [cel@picasso cthon04]$
> 


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: connectathon special test failure in recent kernels

[Chuck Lever]

On 8/8/06, Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> On Tue, 2006-08-08 at 15:20 -0400, Chuck Lever wrote:
> > Is the connectathon holey test failure going to be fixed before 2.6.18
> > is finalized?
>
> Depends. Have you traced it in order to figure out what is wrong?

Ah.  Bruce reported this problem a while back, and said that it goes
away if one of your recent patches to fs/nfs/read.c is reverted.
Bruce?

-- 
"We who cut mere stones must always be envisioning cathedrals"
   -- Quarry worker's creed

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: connectathon special test failure in recent kernels

[Steve Dickson]

Chuck Lever wrote:
> On 8/8/06, Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> 
>>On Tue, 2006-08-08 at 15:20 -0400, Chuck Lever wrote:
>>
>>>Is the connectathon holey test failure going to be fixed before 2.6.18
>>>is finalized?
>>
>>Depends. Have you traced it in order to figure out what is wrong?
> 
> 
> Ah.  Bruce reported this problem a while back, and said that it goes
> away if one of your recent patches to fs/nfs/read.c is reverted.
> Bruce?
Well the patch in question is:

commit 1de3fc12ea085690547a54b6efa01c7348f1cebd
tree ea865786120cfcefac563c54693fef8d3d718f10
parent 128e6ced247cda88f96fa9f2e4ba8b2c4a681560
author Trond Myklebust <Trond.Myklebust@netapp.com> Thu, 25 May 2006
09:40:44 -0400
committer Trond Myklebust <Trond.Myklebust@netapp.com> Fri, 09 Jun 2006
17:34:03 -0400

NFS: Clean up and fix page zeroing when we have short reads

The code that is supposed to zero the uninitialised partial pages when
the server returns a short read is currently broken: it looks at the
nfs_page wb_pgbase and wb_bytes fields instead of the equivalent
nfs_read_data values when deciding where to start truncating the page.

Also ensure that we are more careful about setting PG_uptodate
before retrying a short read: the retry will change the nfs_read_data
args.pgbase and args.count.

I'm looking into now... but this patch definitely breaks the holy
test...

steved.


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: connectathon special test failure in recent kernels

[Chuck Lever]

Steve-

For the record, you did mention to me at one point that you saw this
against Linux *and* Solaris NFS servers, right?

On 8/17/06, Steve Dickson <SteveD@redhat.com> wrote:
>
>
> Chuck Lever wrote:
> > On 8/8/06, Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> >
> >>On Tue, 2006-08-08 at 15:20 -0400, Chuck Lever wrote:
> >>
> >>>Is the connectathon holey test failure going to be fixed before 2.6.18
> >>>is finalized?
> >>
> >>Depends. Have you traced it in order to figure out what is wrong?
> >
> >
> > Ah.  Bruce reported this problem a while back, and said that it goes
> > away if one of your recent patches to fs/nfs/read.c is reverted.
> > Bruce?
> Well the patch in question is:
>
> commit 1de3fc12ea085690547a54b6efa01c7348f1cebd
> tree ea865786120cfcefac563c54693fef8d3d718f10
> parent 128e6ced247cda88f96fa9f2e4ba8b2c4a681560
> author Trond Myklebust <Trond.Myklebust@netapp.com> Thu, 25 May 2006
> 09:40:44 -0400
> committer Trond Myklebust <Trond.Myklebust@netapp.com> Fri, 09 Jun 2006
> 17:34:03 -0400
>
> NFS: Clean up and fix page zeroing when we have short reads
>
> The code that is supposed to zero the uninitialised partial pages when
> the server returns a short read is currently broken: it looks at the
> nfs_page wb_pgbase and wb_bytes fields instead of the equivalent
> nfs_read_data values when deciding where to start truncating the page.
>
> Also ensure that we are more careful about setting PG_uptodate
> before retrying a short read: the retry will change the nfs_read_data
> args.pgbase and args.count.
>
> I'm looking into now... but this patch definitely breaks the holy
> test...
>
> steved.
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> NFS maillist  -  NFS@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs
>


-- 
"We who cut mere stones must always be envisioning cathedrals"
   -- Quarry worker's creed

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: connectathon special test failure in recent kernels

[Steve Dickson]

Chuck Lever wrote:
> Steve-
> 
> For the record, you did mention to me at one point that you saw this
> against Linux *and* Solaris NFS servers, right?
This is true.... This failure happens against both flavors...

steved.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: connectathon special test failure in recent kernels

[Trond Myklebust]

On Thu, 2006-08-17 at 13:07 -0400, Steve Dickson wrote:
> 
> Chuck Lever wrote:
> > Steve-
> > 
> > For the record, you did mention to me at one point that you saw this
> > against Linux *and* Solaris NFS servers, right?
> This is true.... This failure happens against both flavors...

Could you send us an example of 'fsx' output that demonstrates the
problem?

Cheers,
  Trond

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: connectathon special test failure in recent kernels

[Steve Dickson]

Trond Myklebust wrote:
> 
> Could you send us an example of 'fsx' output that demonstrates the
> problem?
hmmm... fsx? What does the fsx have to do with the special tests of
the connectathon failing... I guess I'm missing something...
anyways... I'll try to run some fsx test runs asaic...

steved.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: connectathon special test failure in recent kernels

[Trond Myklebust]

On Thu, 2006-08-17 at 16:56 -0400, Steve Dickson wrote:
> Trond Myklebust wrote:
> > 
> > Could you send us an example of 'fsx' output that demonstrates the
> > problem?
> hmmm... fsx? What does the fsx have to do with the special tests of
> the connectathon failing... I guess I'm missing something...
> anyways... I'll try to run some fsx test runs asaic...

fsx creates holes in files left, right and center, and then tests for
correctness. If there is a problem with the read patch, and hole
creation, then fsx should find it and provide you with a nice dump of
what went wrong, where, and what sequence of events lead up to the
problem.

Cheers,
  Trond

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: connectathon special test failure in recent kernels

[J. Bruce Fields]

On Thu, Aug 17, 2006 at 06:37:31PM -0400, Trond Myklebust wrote:
> On Thu, 2006-08-17 at 16:56 -0400, Steve Dickson wrote:
> > Trond Myklebust wrote:
> > > 
> > > Could you send us an example of 'fsx' output that demonstrates the
> > > problem?
> > hmmm... fsx? What does the fsx have to do with the special tests of
> > the connectathon failing... I guess I'm missing something...
> > anyways... I'll try to run some fsx test runs asaic...
> 
> fsx creates holes in files left, right and center, and then tests for
> correctness. If there is a problem with the read patch, and hole
> creation, then fsx should find it and provide you with a nice dump of
> what went wrong, where, and what sequence of events lead up to the
> problem.

The holey test run on its own also gives a pretty short simple test
case.--b.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: connectathon special test failure in recent kernels

[Trond Myklebust]

On Thu, 2006-08-17 at 22:50 -0400, J. Bruce Fields wrote:
> The holey test run on its own also gives a pretty short simple test
> case.--b.

It would if it actually reproduced the problem on my setup. As it
doesn't, fsx is the second best option since it produces a full dump of
the offending file section.

Trond

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

[PATCH] connectathon special test failure in recent kernels

[Steve Dickson]

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

Steve Dickson wrote:
> Well the patch in question is:
> 
> commit 1de3fc12ea085690547a54b6efa01c7348f1cebd
> tree ea865786120cfcefac563c54693fef8d3d718f10
> parent 128e6ced247cda88f96fa9f2e4ba8b2c4a681560
> author Trond Myklebust <Trond.Myklebust@netapp.com> Thu, 25 May 2006
> 09:40:44 -0400
> committer Trond Myklebust <Trond.Myklebust@netapp.com> Fri, 09 Jun 2006
> 17:34:03 -0400
> 
> NFS: Clean up and fix page zeroing when we have short reads

Attached is that patch that fixes the regression caused by
the above patch... I've tested with both the connectathon test suite
and the fsx test suite.

The patch is based on the 2.6.18-rc4 kernel tree.

steved.

[-- Attachment #2: linux-2.6.18-rc4-nfs-holey.patch --]
[-- Type: text/x-patch, Size: 1144 bytes --]

The patch fixes a regression that causes the special tests
of the Connectation tests suite to fail. When a hole in a 
file is created (like the holey test does), the page will
be allocated but there will be nothing read into it. The
means the number of byte read from the server will be
zero (i.e.  data->res.count). In the case, the page
still has PageUptodate-ed which is what this patch
does.

Signed-off-by: Steve Dickson <steved@redhat.com>

--- linux-2.6.18-rc4/fs/nfs/read.c.orig	2006-08-20 13:49:22.000000000 -0400
+++ linux-2.6.18-rc4/fs/nfs/read.c	2006-08-20 13:58:59.000000000 -0400
@@ -476,13 +476,14 @@
 	unsigned int base = data->args.pgbase;
 	struct page **pages;
 
-	if (unlikely(count == 0))
-		return;
 	pages = &data->args.pages[base >> PAGE_CACHE_SHIFT];
 	base &= ~PAGE_CACHE_MASK;
 	count += base;
-	for (;count >= PAGE_CACHE_SIZE; count -= PAGE_CACHE_SIZE, pages++)
+	if (count == 0) 
 		SetPageUptodate(*pages);
+	else 
+		for (;count >= PAGE_CACHE_SIZE; count -= PAGE_CACHE_SIZE, pages++)
+			SetPageUptodate(*pages);
 	/*
 	 * Was this an eof or a short read? If the latter, don't mark the page
 	 * as uptodate yet.

[-- Attachment #3: Type: text/plain, Size: 373 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs