From: Dave Hansen <haveblue@us.ibm.com>
To: schwidefsky@de.ibm.com
Cc: akpm@osdl.org, virtualization@lists.osdl.org,
frankeh@watson.ibm.com, rhim@cc.gateh.edu,
nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/9] Guest page hinting: unused / free pages.
Date: Fri, 01 Sep 2006 08:56:02 -0700 [thread overview]
Message-ID: <1157126162.28577.104.camel@localhost.localdomain> (raw)
In-Reply-To: <1157125420.21733.28.camel@localhost>
On Fri, 2006-09-01 at 17:43 +0200, Martin Schwidefsky wrote:
> This question did come up already. arch_free_page() is done before the
> PageReserved() check so it isn't suitable for stable/unused state
> transitions. You can argue that arch_free_page() should be moved but who
> knows what the architecture defined function is supposed to do?
> page_set_stable/page_set_unused on the other hand have a clearly defined
> meaning.
With a patch set this large, I think it would at least be a nice thing
to go through and review the other architectures' uses.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: schwidefsky@de.ibm.com
Cc: linux-kernel@vger.kernel.org, virtualization@lists.osdl.org,
akpm@osdl.org, nickpiggin@yahoo.com.au, frankeh@watson.ibm.com,
rhim@cc.gateh.edu
Subject: Re: [patch 1/9] Guest page hinting: unused / free pages.
Date: Fri, 01 Sep 2006 08:56:02 -0700 [thread overview]
Message-ID: <1157126162.28577.104.camel@localhost.localdomain> (raw)
In-Reply-To: <1157125420.21733.28.camel@localhost>
On Fri, 2006-09-01 at 17:43 +0200, Martin Schwidefsky wrote:
> This question did come up already. arch_free_page() is done before the
> PageReserved() check so it isn't suitable for stable/unused state
> transitions. You can argue that arch_free_page() should be moved but who
> knows what the architecture defined function is supposed to do?
> page_set_stable/page_set_unused on the other hand have a clearly defined
> meaning.
With a patch set this large, I think it would at least be a nice thing
to go through and review the other architectures' uses.
-- Dave
next prev parent reply other threads:[~2006-09-01 15:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 11:09 [patch 1/9] Guest page hinting: unused / free pages Martin Schwidefsky
2006-09-01 15:33 ` Dave Hansen
2006-09-01 15:33 ` Dave Hansen
2006-09-01 15:43 ` Martin Schwidefsky
2006-09-01 15:56 ` Dave Hansen [this message]
2006-09-01 15:56 ` Dave Hansen
2006-09-01 16:05 ` Martin Schwidefsky
2006-09-01 16:10 ` Dave Hansen
2006-09-01 16:10 ` Dave Hansen
2006-09-12 22:47 ` Rik van Riel
2006-09-13 0:07 ` Hubertus Franke
2006-09-13 0:07 ` Hubertus Franke
2006-09-13 1:29 ` Rik van Riel
2006-09-13 8:56 ` Martin Schwidefsky
2006-09-13 8:56 ` Martin Schwidefsky
2006-09-13 12:06 ` Hubertus Franke
2006-09-13 12:45 ` Martin Schwidefsky
2006-09-13 12:45 ` Martin Schwidefsky
2006-09-13 13:06 ` Hubertus Franke
2006-09-13 14:45 ` Rik van Riel
2006-09-13 14:59 ` Martin Schwidefsky
2006-09-13 14:59 ` Martin Schwidefsky
2006-09-13 17:05 ` Hubertus Franke
-- strict thread matches above, loose matches on Subject: below --
2006-08-24 14:29 Martin Schwidefsky, Martin Schwidefsky, Hubertus Franke, Himanshu Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157126162.28577.104.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=frankeh@watson.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=rhim@cc.gateh.edu \
--cc=schwidefsky@de.ibm.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.