[PATCH 1/5] ASoC: Build files

[PATCH 1/5] ASoC: Build files

[Liam Girdwood]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

This patch adds support for building the ASoC core and the dynamic audio
power management support.

Signed-off-by: Liam Girdwood <liam.girdwood@wolfsonmicro.com>


[-- Attachment #2: asoc-build.patch --]
[-- Type: text/x-patch, Size: 1671 bytes --]

Index: alsa-kernel/Kconfig
===================================================================
--- alsa-kernel.orig/Kconfig
+++ alsa-kernel/Kconfig
@@ -76,6 +76,8 @@ source "sound/sparc/Kconfig"
 
 source "sound/parisc/Kconfig"
 
+source "sound/soc/Kconfig"
+
 endmenu
 
 menu "Open Sound System"
Index: alsa-kernel/Makefile
===================================================================
--- alsa-kernel.orig/Makefile
+++ alsa-kernel/Makefile
@@ -4,7 +4,7 @@
 obj-$(CONFIG_SOUND) += soundcore.o
 obj-$(CONFIG_SOUND_PRIME) += oss/
 obj-$(CONFIG_DMASOUND) += oss/
-obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/
+obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/ soc/
 obj-$(CONFIG_SND_AOA) += aoa/
 
 ifeq ($(CONFIG_SND),y)
Index: alsa-kernel/soc/Kconfig
===================================================================
--- /dev/null
+++ alsa-kernel/soc/Kconfig
@@ -0,0 +1,18 @@
+#
+# SoC audio configuration
+#
+
+menu "SoC audio support"
+
+config SND_SOC
+	tristate "SoC audio support"
+	---help---
+
+	  If you want SoC support, you should say Y here and also to the
+	  specific driver for your SoC below. You will also need to select the
+	  specific codec(s) attached to the SoC
+
+	  This SoC audio support can also be built as a module.  If so, the module
+	  will be called snd-soc-core.
+
+endmenu
Index: alsa-kernel/soc/Makefile
===================================================================
--- /dev/null
+++ alsa-kernel/soc/Makefile
@@ -0,0 +1,4 @@
+snd-soc-core-objs := soc-core.o soc-dapm.o
+
+obj-$(CONFIG_SND_SOC)	+= snd-soc-core.o
+

[-- Attachment #3: Type: text/plain, Size: 373 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: [PATCH 1/5] ASoC: Build files

[Takashi Iwai]

At Fri, 15 Sep 2006 14:17:32 +0100,
Liam Girdwood wrote:
> 
> Index: alsa-kernel/soc/Kconfig
> ===================================================================
> --- /dev/null
> +++ alsa-kernel/soc/Kconfig
> @@ -0,0 +1,18 @@
> +#
> +# SoC audio configuration
> +#
> +
> +menu "SoC audio support"
> +
> +config SND_SOC
> +	tristate "SoC audio support"

Don't you need dependencies?

Also, changes for Kconfig and Makefile are usually the last patch so
that you don't break build.  A minor issue, though...


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: [PATCH 1/5] ASoC: Build files

[Liam Girdwood]

On Tue, 2006-09-19 at 14:20 +0200, Takashi Iwai wrote:
> At Fri, 15 Sep 2006 14:17:32 +0100,
> Liam Girdwood wrote:
> > 
> > Index: alsa-kernel/soc/Kconfig
> > ===================================================================
> > --- /dev/null
> > +++ alsa-kernel/soc/Kconfig
> > @@ -0,0 +1,18 @@
> > +#
> > +# SoC audio configuration
> > +#
> > +
> > +menu "SoC audio support"
> > +
> > +config SND_SOC
> > +	tristate "SoC audio support"
> 
> Don't you need dependencies?
> 

I've set the deps (for each platform) in the child (asoc) Kconfig. 

Liam


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: [PATCH 1/5] ASoC: Build files

[Takashi Iwai]

At Fri, 22 Sep 2006 17:56:11 +0100,
Liam Girdwood wrote:
> 
> On Tue, 2006-09-19 at 14:20 +0200, Takashi Iwai wrote:
> > At Fri, 15 Sep 2006 14:17:32 +0100,
> > Liam Girdwood wrote:
> > > 
> > > Index: alsa-kernel/soc/Kconfig
> > > ===================================================================
> > > --- /dev/null
> > > +++ alsa-kernel/soc/Kconfig
> > > @@ -0,0 +1,18 @@
> > > +#
> > > +# SoC audio configuration
> > > +#
> > > +
> > > +menu "SoC audio support"
> > > +
> > > +config SND_SOC
> > > +	tristate "SoC audio support"
> > 
> > Don't you need dependencies?
> > 
> 
> I've set the deps (for each platform) in the child (asoc) Kconfig. 

But soc/Kconfig is always evaluated even if CONFIG_SND=n.
If SoC depends on ALSA core layer, it should have "depends on SND"
or "select SND" at least.  Otherwise you can get a build error.


BTW, any drivers using SoC are planned to be merged soon, too?
It's always better to have a working driver together with the core
stuff for pushing to upstream.


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: [PATCH 1/5] ASoC: Build files

[Liam Girdwood]

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

On Fri, 2006-09-29 at 14:01 +0200, Takashi Iwai wrote:
> At Fri, 22 Sep 2006 17:56:11 +0100,
> Liam Girdwood wrote:
> > 
> > On Tue, 2006-09-19 at 14:20 +0200, Takashi Iwai wrote:
> > > At Fri, 15 Sep 2006 14:17:32 +0100,
> > > Liam Girdwood wrote:
> > > > 
> > > > Index: alsa-kernel/soc/Kconfig
> > > > ===================================================================
> > > > --- /dev/null
> > > > +++ alsa-kernel/soc/Kconfig
> > > > @@ -0,0 +1,18 @@
> > > > +#
> > > > +# SoC audio configuration
> > > > +#
> > > > +
> > > > +menu "SoC audio support"
> > > > +
> > > > +config SND_SOC
> > > > +	tristate "SoC audio support"
> > > 
> > > Don't you need dependencies?
> > > 
> > 
> > I've set the deps (for each platform) in the child (asoc) Kconfig. 
> 
> But soc/Kconfig is always evaluated even if CONFIG_SND=n.
> If SoC depends on ALSA core layer, it should have "depends on SND"
> or "select SND" at least.  Otherwise you can get a build error.
> 
> 

Fixed. 

> BTW, any drivers using SoC are planned to be merged soon, too?
> It's always better to have a working driver together with the core
> stuff for pushing to upstream.
> 
> 

Np, I was waiting until after 1.0.13 final was released. It's late
today, so I'll submit on Monday.


Liam


[-- Attachment #2: asoc-build.patch --]
[-- Type: text/x-patch, Size: 1691 bytes --]

Index: alsa-kernel/Kconfig
===================================================================
--- alsa-kernel.orig/Kconfig
+++ alsa-kernel/Kconfig
@@ -76,6 +76,8 @@ source "sound/sparc/Kconfig"
 
 source "sound/parisc/Kconfig"
 
+source "sound/soc/Kconfig"
+
 endmenu
 
 menu "Open Sound System"
Index: alsa-kernel/Makefile
===================================================================
--- alsa-kernel.orig/Makefile
+++ alsa-kernel/Makefile
@@ -4,7 +4,7 @@
 obj-$(CONFIG_SOUND) += soundcore.o
 obj-$(CONFIG_SOUND_PRIME) += oss/
 obj-$(CONFIG_DMASOUND) += oss/
-obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/
+obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/ soc/
 obj-$(CONFIG_SND_AOA) += aoa/
 
 ifeq ($(CONFIG_SND),y)
Index: alsa-kernel/soc/Kconfig
===================================================================
--- /dev/null
+++ alsa-kernel/soc/Kconfig
@@ -0,0 +1,19 @@
+#
+# SoC audio configuration
+#
+
+menu "SoC audio support"
+	depends on SND!=n
+
+config SND_SOC
+	tristate "SoC audio support"
+	---help---
+
+	  If you want SoC support, you should say Y here and also to the
+	  specific driver for your SoC below. You will also need to select the
+	  specific codec(s) attached to the SoC
+
+	  This SoC audio support can also be built as a module.  If so, the module
+	  will be called snd-soc-core.
+
+endmenu
Index: alsa-kernel/soc/Makefile
===================================================================
--- /dev/null
+++ alsa-kernel/soc/Makefile
@@ -0,0 +1,4 @@
+snd-soc-core-objs := soc-core.o soc-dapm.o
+
+obj-$(CONFIG_SND_SOC)	+= snd-soc-core.o
+

[-- Attachment #3: Type: text/plain, Size: 348 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: [PATCH 1/5] ASoC: Build files

[Takashi Iwai]

At Fri, 29 Sep 2006 14:56:07 +0100,
Liam Girdwood wrote:
> 
> On Fri, 2006-09-29 at 14:01 +0200, Takashi Iwai wrote:
> > At Fri, 22 Sep 2006 17:56:11 +0100,
> > Liam Girdwood wrote:
> > > 
> > > On Tue, 2006-09-19 at 14:20 +0200, Takashi Iwai wrote:
> > > > At Fri, 15 Sep 2006 14:17:32 +0100,
> > > > Liam Girdwood wrote:
> > > > > 
> > > > > Index: alsa-kernel/soc/Kconfig
> > > > > ===================================================================
> > > > > --- /dev/null
> > > > > +++ alsa-kernel/soc/Kconfig
> > > > > @@ -0,0 +1,18 @@
> > > > > +#
> > > > > +# SoC audio configuration
> > > > > +#
> > > > > +
> > > > > +menu "SoC audio support"
> > > > > +
> > > > > +config SND_SOC
> > > > > +	tristate "SoC audio support"
> > > > 
> > > > Don't you need dependencies?
> > > > 
> > > 
> > > I've set the deps (for each platform) in the child (asoc) Kconfig. 
> > 
> > But soc/Kconfig is always evaluated even if CONFIG_SND=n.
> > If SoC depends on ALSA core layer, it should have "depends on SND"
> > or "select SND" at least.  Otherwise you can get a build error.
> > 
> > 
> 
> Fixed. 
> 
> > BTW, any drivers using SoC are planned to be merged soon, too?
> > It's always better to have a working driver together with the core
> > stuff for pushing to upstream.
> > 
> > 
> 
> Np, I was waiting until after 1.0.13 final was released. It's late
> today, so I'll submit on Monday.

1.0.13 final will be released really soon, so it's fine to submit on
Monday.


Thanks,

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV