Re: [PATCH 1/7] KVM: userspace interface

[Steven Rostedt <rostedt@goodmis.org>]

On Thu, 2006-10-19 at 15:47 +0200, Avi Kivity wrote:
> This patch defines a bunch of ioctl()s on /dev/kvm.  The ioctl()s allow
> adding
> memory to a virtual machine, adding a virtual cpu to a virtual machine (at
> most one at this time), transferring control to the virtual cpu, and
> querying
> about guest pages changed by the virtual machine.
> 
> Signed-off-by: Yaniv Kamay <yaniv@qumranet.com>
> Signed-off-by: Avi Kivity <avi@qumranet.com>
> 
> Index: linux-2.6/include/linux/kvm.h
> ===================================================================
> --- /dev/null
> +++ linux-2.6/include/linux/kvm.h

[...]

> +
> +/* for KVM_GET_REGS and KVM_SET_REGS */
> +struct kvm_regs {
> +    /* in */
> +    __u32 vcpu;
> +    __u32 padding;
> +
> +    /* out (KVM_GET_REGS) / in (KVM_SET_REGS) */
> +    __u64 rax, rbx, rcx, rdx;
> +    __u64 rsi, rdi, rsp, rbp;
> +    __u64 r8,  r9,  r10, r11;
> +    __u64 r12, r13, r14, r15;
> +    __u64 rip, rflags;
> +};
> +

I know this is for userspace too, but still. Shouldn't this be in
include/asm-x86_64 and not include/linux.

-- Steve