Re: [PATCH 1/7] KVM: userspace interface

[Avi Kivity <avi@qumranet.com>]

Steven Rostedt wrote:
>> +
>> +/* for KVM_GET_REGS and KVM_SET_REGS */
>> +struct kvm_regs {
>> +    /* in */
>> +    __u32 vcpu;
>> +    __u32 padding;
>> +
>> +    /* out (KVM_GET_REGS) / in (KVM_SET_REGS) */
>> +    __u64 rax, rbx, rcx, rdx;
>> +    __u64 rsi, rdi, rsp, rbp;
>> +    __u64 r8,  r9,  r10, r11;
>> +    __u64 r12, r13, r14, r15;
>> +    __u64 rip, rflags;
>> +};
>> +
>>     
>
> I know this is for userspace too, but still. Shouldn't this be in
> include/asm-x86_64 and not include/linux.
>   

Most of this file is arch-independent and could be used for other 
virtualization-capable architectures.  I could this snippet to 
asm-x86_64 but where would it leave i386?

(i386 needs access to 64-bit registers since we support 64-bit guests on 
a 64-bit host with a 32-bit userspace)

-- 
error compiling committee.c: too many arguments to function