From: Dave Hansen <haveblue@us.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mm@kvack.org, kmannth@us.ibm.com,
linux-kernel@vger.kernel.org, hch@infradead.org,
linuxppc-dev@ozlabs.org, paulus@samba.org, mkravetz@us.ibm.com,
gone@us.ibm.com, cbe-oss-dev@ozlabs.org
Subject: Re: [PATCH] Fix sparsemem on Cell
Date: Mon, 18 Dec 2006 13:13:57 -0800 [thread overview]
Message-ID: <1166476437.8648.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20061216170353.2dfa27b1.kamezawa.hiroyu@jp.fujitsu.com>
On Sat, 2006-12-16 at 17:03 +0900, KAMEZAWA Hiroyuki wrote:
> /* add this memory to iomem resource */
> static struct resource *register_memory_resource(u64 start, u64 size)
> {
> @@ -273,10 +284,13 @@
> if (ret)
> goto error;
> }
> + atomic_inc(&memory_hotadd_count);
>
> /* call arch's memory hotadd */
> ret = arch_add_memory(nid, start, size);
>
> + atomic_dec(&memory_hotadd_count);
I'd be willing to be that this will work just fine. But, I think we can
do it without any static state at all, if we just pass a runtime-or-not
flag down into the arch_add_memory() call chain.
I'll code that up so we can compare to yours.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>,
apw@shadowen.org, cbe-oss-dev@ozlabs.org,
linuxppc-dev@ozlabs.org, linux-mm@kvack.org, mkravetz@us.ibm.com,
hch@infradead.org, jk@ozlabs.org, linux-kernel@vger.kernel.org,
paulus@samba.org, benh@kernel.crashing.org, gone@us.ibm.com,
kmannth@us.ibm.com
Subject: Re: [PATCH] Fix sparsemem on Cell
Date: Mon, 18 Dec 2006 13:13:57 -0800 [thread overview]
Message-ID: <1166476437.8648.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20061216170353.2dfa27b1.kamezawa.hiroyu@jp.fujitsu.com>
On Sat, 2006-12-16 at 17:03 +0900, KAMEZAWA Hiroyuki wrote:
> /* add this memory to iomem resource */
> static struct resource *register_memory_resource(u64 start, u64 size)
> {
> @@ -273,10 +284,13 @@
> if (ret)
> goto error;
> }
> + atomic_inc(&memory_hotadd_count);
>
> /* call arch's memory hotadd */
> ret = arch_add_memory(nid, start, size);
>
> + atomic_dec(&memory_hotadd_count);
I'd be willing to be that this will work just fine. But, I think we can
do it without any static state at all, if we just pass a runtime-or-not
flag down into the arch_add_memory() call chain.
I'll code that up so we can compare to yours.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>,
apw@shadowen.org, cbe-oss-dev@ozlabs.org,
linuxppc-dev@ozlabs.org, linux-mm@kvack.org, mkravetz@us.ibm.com,
hch@infradead.org, jk@ozlabs.org, linux-kernel@vger.kernel.org,
paulus@samba.org, benh@kernel.crashing.org, gone@us.ibm.com,
kmannth@us.ibm.com
Subject: Re: [PATCH] Fix sparsemem on Cell
Date: Mon, 18 Dec 2006 13:13:57 -0800 [thread overview]
Message-ID: <1166476437.8648.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20061216170353.2dfa27b1.kamezawa.hiroyu@jp.fujitsu.com>
On Sat, 2006-12-16 at 17:03 +0900, KAMEZAWA Hiroyuki wrote:
> /* add this memory to iomem resource */
> static struct resource *register_memory_resource(u64 start, u64 size)
> {
> @@ -273,10 +284,13 @@
> if (ret)
> goto error;
> }
> + atomic_inc(&memory_hotadd_count);
>
> /* call arch's memory hotadd */
> ret = arch_add_memory(nid, start, size);
>
> + atomic_dec(&memory_hotadd_count);
I'd be willing to be that this will work just fine. But, I think we can
do it without any static state at all, if we just pass a runtime-or-not
flag down into the arch_add_memory() call chain.
I'll code that up so we can compare to yours.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-12-18 21:13 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 16:53 [PATCH] Fix sparsemem on Cell Dave Hansen
2006-12-15 16:53 ` Dave Hansen
2006-12-15 16:53 ` Dave Hansen
2006-12-15 17:11 ` Andy Whitcroft
2006-12-15 17:11 ` Andy Whitcroft
2006-12-15 17:11 ` Andy Whitcroft
2006-12-15 17:24 ` Dave Hansen
2006-12-15 17:24 ` Dave Hansen
2006-12-15 17:24 ` Dave Hansen
2006-12-15 19:45 ` Andrew Morton
2006-12-15 19:45 ` Andrew Morton
2006-12-15 19:45 ` Andrew Morton
2006-12-16 8:03 ` KAMEZAWA Hiroyuki
2006-12-16 8:03 ` KAMEZAWA Hiroyuki
2006-12-16 8:03 ` KAMEZAWA Hiroyuki
2006-12-18 21:13 ` Dave Hansen [this message]
2006-12-18 21:13 ` Dave Hansen
2006-12-18 21:13 ` Dave Hansen
2006-12-18 22:15 ` Christoph Hellwig
2006-12-18 22:15 ` Christoph Hellwig
2006-12-18 22:15 ` Christoph Hellwig
2006-12-18 22:54 ` Arnd Bergmann
2006-12-18 22:54 ` Arnd Bergmann
2006-12-18 22:54 ` Arnd Bergmann
2006-12-18 23:16 ` Dave Hansen
2006-12-18 23:16 ` Dave Hansen
2006-12-18 23:16 ` Dave Hansen
2006-12-19 0:16 ` KAMEZAWA Hiroyuki
2006-12-19 0:16 ` KAMEZAWA Hiroyuki
2006-12-19 0:16 ` KAMEZAWA Hiroyuki
2006-12-19 8:59 ` Arnd Bergmann
2006-12-19 8:59 ` Arnd Bergmann
2006-12-19 8:59 ` Arnd Bergmann
2006-12-19 19:34 ` Dave Hansen
2006-12-19 19:34 ` Dave Hansen
2006-12-19 19:34 ` Dave Hansen
2007-01-06 1:10 ` [PATCH] Fix sparsemem on Cell (take 3) Dave Hansen
2007-01-06 1:10 ` Dave Hansen
2007-01-06 1:10 ` Dave Hansen
2007-01-06 4:52 ` John Rose
2007-01-06 4:52 ` John Rose
2007-01-06 4:52 ` John Rose
2007-01-07 8:58 ` Dave Hansen
2007-01-07 8:58 ` Dave Hansen
2007-01-07 8:58 ` Dave Hansen
2007-01-07 12:07 ` Arnd Bergmann
2007-01-07 12:07 ` Arnd Bergmann
2007-01-07 12:07 ` Arnd Bergmann
2007-01-08 6:31 ` Tim Pepper
2007-01-08 6:31 ` Tim Pepper
2007-01-08 6:47 ` Tim Pepper
2007-01-08 6:47 ` Tim Pepper
2007-01-08 6:47 ` Tim Pepper
2006-12-15 17:22 ` [PATCH] Fix sparsemem on Cell Michael Buesch
2006-12-15 17:22 ` Michael Buesch
2006-12-15 17:22 ` Michael Buesch
2006-12-15 17:57 ` Dave Hansen
2006-12-15 17:57 ` Dave Hansen
2006-12-15 17:57 ` Dave Hansen
2006-12-15 20:21 ` Benjamin Herrenschmidt
2006-12-15 20:21 ` Benjamin Herrenschmidt
2006-12-15 20:21 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2006-12-15 17:14 Dave Hansen
2006-12-15 17:14 ` Dave Hansen
2006-12-15 17:14 ` Dave Hansen
2006-12-17 23:02 ` Arnd Bergmann
2006-12-17 23:02 ` Arnd Bergmann
2006-12-17 23:02 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1166476437.8648.7.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=gone@us.ibm.com \
--cc=hch@infradead.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kmannth@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mkravetz@us.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.