From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, hch@infradead.org,
linux-mm@kvack.org, paulus@samba.org, mkravetz@us.ibm.com,
gone@us.ibm.com, cbe-oss-dev@ozlabs.org
Subject: Re: [PATCH] Fix sparsemem on Cell
Date: Mon, 18 Dec 2006 00:02:09 +0100 [thread overview]
Message-ID: <200612180002.11079.arnd@arndb.de> (raw)
In-Reply-To: <20061215171411.E3EE01AD@localhost.localdomain>
On Friday 15 December 2006 18:14, Dave Hansen wrote:
> +=A0=A0=A0=A0=A0=A0=A0if (system_state >=3D SYSTEM_RUNNING)
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0return 1;
> + if (!early_pfn_valid(pfn))
> + return 0;
> + if (!early_pfn_in_nid(pfn, nid))
> + return 0;
I haven't tried it, but I assume this is still wrong. On cell,
we didn't actually hit the case where the init sections have
been overwritten, since we call __add_pages from an initcall.
However, the pages we add are not part of the early_node_map,
so early_pfn_in_nid() returns a bogus result, causing some
page structs not to get initialized. I believe your patch
is going in the right direction, but it does not solve the
bug we have...
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Dave Hansen <haveblue@us.ibm.com>,
cbe-oss-dev@ozlabs.org, akpm@osdl.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, hch@infradead.org,
paulus@samba.org, mkravetz@us.ibm.com, gone@us.ibm.com
Subject: Re: [PATCH] Fix sparsemem on Cell
Date: Mon, 18 Dec 2006 00:02:09 +0100 [thread overview]
Message-ID: <200612180002.11079.arnd@arndb.de> (raw)
In-Reply-To: <20061215171411.E3EE01AD@localhost.localdomain>
On Friday 15 December 2006 18:14, Dave Hansen wrote:
> + if (system_state >= SYSTEM_RUNNING)
> + return 1;
> + if (!early_pfn_valid(pfn))
> + return 0;
> + if (!early_pfn_in_nid(pfn, nid))
> + return 0;
I haven't tried it, but I assume this is still wrong. On cell,
we didn't actually hit the case where the init sections have
been overwritten, since we call __add_pages from an initcall.
However, the pages we add are not part of the early_node_map,
so early_pfn_in_nid() returns a bogus result, causing some
page structs not to get initialized. I believe your patch
is going in the right direction, but it does not solve the
bug we have...
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Dave Hansen <haveblue@us.ibm.com>,
cbe-oss-dev@ozlabs.org, akpm@osdl.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, hch@infradead.org,
paulus@samba.org, mkravetz@us.ibm.com, gone@us.ibm.com
Subject: Re: [PATCH] Fix sparsemem on Cell
Date: Mon, 18 Dec 2006 00:02:09 +0100 [thread overview]
Message-ID: <200612180002.11079.arnd@arndb.de> (raw)
In-Reply-To: <20061215171411.E3EE01AD@localhost.localdomain>
On Friday 15 December 2006 18:14, Dave Hansen wrote:
> + if (system_state >= SYSTEM_RUNNING)
> + return 1;
> + if (!early_pfn_valid(pfn))
> + return 0;
> + if (!early_pfn_in_nid(pfn, nid))
> + return 0;
I haven't tried it, but I assume this is still wrong. On cell,
we didn't actually hit the case where the init sections have
been overwritten, since we call __add_pages from an initcall.
However, the pages we add are not part of the early_node_map,
so early_pfn_in_nid() returns a bogus result, causing some
page structs not to get initialized. I believe your patch
is going in the right direction, but it does not solve the
bug we have...
Arnd <><
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-12-17 23:02 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 17:14 [PATCH] Fix sparsemem on Cell Dave Hansen
2006-12-15 17:14 ` Dave Hansen
2006-12-15 17:14 ` Dave Hansen
2006-12-17 23:02 ` Arnd Bergmann [this message]
2006-12-17 23:02 ` Arnd Bergmann
2006-12-17 23:02 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2006-12-15 16:53 Dave Hansen
2006-12-15 16:53 ` Dave Hansen
2006-12-15 16:53 ` Dave Hansen
2006-12-15 17:11 ` Andy Whitcroft
2006-12-15 17:11 ` Andy Whitcroft
2006-12-15 17:11 ` Andy Whitcroft
2006-12-15 17:24 ` Dave Hansen
2006-12-15 17:24 ` Dave Hansen
2006-12-15 17:24 ` Dave Hansen
2006-12-15 19:45 ` Andrew Morton
2006-12-15 19:45 ` Andrew Morton
2006-12-15 19:45 ` Andrew Morton
2006-12-16 8:03 ` KAMEZAWA Hiroyuki
2006-12-16 8:03 ` KAMEZAWA Hiroyuki
2006-12-16 8:03 ` KAMEZAWA Hiroyuki
2006-12-18 21:13 ` Dave Hansen
2006-12-18 21:13 ` Dave Hansen
2006-12-18 21:13 ` Dave Hansen
2006-12-18 22:15 ` Christoph Hellwig
2006-12-18 22:15 ` Christoph Hellwig
2006-12-18 22:15 ` Christoph Hellwig
2006-12-18 22:54 ` Arnd Bergmann
2006-12-18 22:54 ` Arnd Bergmann
2006-12-18 22:54 ` Arnd Bergmann
2006-12-18 23:16 ` Dave Hansen
2006-12-18 23:16 ` Dave Hansen
2006-12-18 23:16 ` Dave Hansen
2006-12-19 0:16 ` KAMEZAWA Hiroyuki
2006-12-19 0:16 ` KAMEZAWA Hiroyuki
2006-12-19 0:16 ` KAMEZAWA Hiroyuki
2006-12-19 8:59 ` Arnd Bergmann
2006-12-19 8:59 ` Arnd Bergmann
2006-12-19 8:59 ` Arnd Bergmann
2006-12-19 19:34 ` Dave Hansen
2006-12-19 19:34 ` Dave Hansen
2006-12-19 19:34 ` Dave Hansen
2006-12-15 17:22 ` Michael Buesch
2006-12-15 17:22 ` Michael Buesch
2006-12-15 17:22 ` Michael Buesch
2006-12-15 17:57 ` Dave Hansen
2006-12-15 17:57 ` Dave Hansen
2006-12-15 17:57 ` Dave Hansen
2006-12-15 20:21 ` Benjamin Herrenschmidt
2006-12-15 20:21 ` Benjamin Herrenschmidt
2006-12-15 20:21 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612180002.11079.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@osdl.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=gone@us.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mkravetz@us.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.