All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	akpm@osdl.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org, rmk@arm.linux.org.uk, sam@ravnborg.org,
	linux-arch@vger.kernel.org
Subject: Re: [PATCH] Complain about missing system calls.
Date: Sat, 10 Mar 2007 10:58:13 +0100	[thread overview]
Message-ID: <1173520693.7128.17.camel@localhost> (raw)
In-Reply-To: <20070309190051.GA20521@one.firstfloor.org>

On Fri, 2007-03-09 at 20:00 +0100, Andi Kleen wrote:
> > Not everybody has a simple indexed list of pointers :)  For example,
> > for vax-linux, we use a struct per syscall with the expected number of
> > on-stack longwords for the call.
> > 
> > So if something "new" is coming up, please keep in mind that it should
> > be flexible enough to represent that. :)
> 
> Are there plans to merge vax any time soon to mainline? 
> 
> Normally we don't care very much about out of tree code, especially
> if it adds complexity like this.
> 
> But I suspect s390 would need number of arguments anyways.

I can't quite follow that line of thought. Why does s390 need the number
of arguments? The wrapper of a compat system call implicitly knows how
many arguments a system calls to do the conversion. For a normal system
call we just call the function. Random example sys_read: the user space
loads the arguments to register %r2, %r3, %r4 and calls the system. The
register are not touched until sys_read is reached. Only sys_read cares
about the number of arguments in this case.

-- 
blue skies,              IBM Deutschland Entwicklung GmbH
   Martin                Vorsitzender des Aufsichtsrats: Johann Weihen
                         Geschäftsführung: Herbert Kircher
Martin Schwidefsky       Sitz der Gesellschaft: Böblingen
Linux on zSeries         Registergericht: Amtsgericht Stuttgart,
   Development           HRB 243294

"Reality continues to ruin my life." - Calvin.



WARNING: multiple messages have this Message-ID (diff)
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: akpm@osdl.org, linux-arch@vger.kernel.org, sam@ravnborg.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	David Woodhouse <dwmw2@infradead.org>,
	rmk@arm.linux.org.uk
Subject: Re: [PATCH] Complain about missing system calls.
Date: Sat, 10 Mar 2007 10:58:13 +0100	[thread overview]
Message-ID: <1173520693.7128.17.camel@localhost> (raw)
In-Reply-To: <20070309190051.GA20521@one.firstfloor.org>

On Fri, 2007-03-09 at 20:00 +0100, Andi Kleen wrote:
> > Not everybody has a simple indexed list of pointers :)  For example,
> > for vax-linux, we use a struct per syscall with the expected number of
> > on-stack longwords for the call.
> > 
> > So if something "new" is coming up, please keep in mind that it should
> > be flexible enough to represent that. :)
> 
> Are there plans to merge vax any time soon to mainline? 
> 
> Normally we don't care very much about out of tree code, especially
> if it adds complexity like this.
> 
> But I suspect s390 would need number of arguments anyways.

I can't quite follow that line of thought. Why does s390 need the number
of arguments? The wrapper of a compat system call implicitly knows how
many arguments a system calls to do the conversion. For a normal system
call we just call the function. Random example sys_read: the user space
loads the arguments to register %r2, %r3, %r4 and calls the system. The
register are not touched until sys_read is reached. Only sys_read cares
about the number of arguments in this case.

-- 
blue skies,              IBM Deutschland Entwicklung GmbH
   Martin                Vorsitzender des Aufsichtsrats: Johann Weihen
                         Geschäftsführung: Herbert Kircher
Martin Schwidefsky       Sitz der Gesellschaft: Böblingen
Linux on zSeries         Registergericht: Amtsgericht Stuttgart,
   Development           HRB 243294

"Reality continues to ruin my life." - Calvin.

  parent reply	other threads:[~2007-03-10  9:58 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-08 23:01 [PATCH] Complain about missing system calls David Woodhouse
2007-03-09  0:14 ` David Miller
2007-03-09  0:14   ` David Miller
2007-03-09  0:18   ` David Woodhouse
2007-03-09  0:18     ` David Woodhouse
2007-03-20 12:12   ` Sam Ravnborg
2007-03-20 12:12     ` Sam Ravnborg
2007-03-09  3:31 ` Anton Blanchard
2007-03-09  3:31   ` Anton Blanchard
2007-03-09  8:43 ` Russell King
2007-03-09  8:43   ` Russell King
2007-03-09 16:11 ` Andi Kleen
2007-03-09 16:11   ` Andi Kleen
2007-03-09 16:38   ` Jan-Benedict Glaw
2007-03-09 16:38     ` Jan-Benedict Glaw
2007-03-09 19:00     ` Andi Kleen
2007-03-09 19:35       ` Jan-Benedict Glaw
2007-03-09 19:35         ` Jan-Benedict Glaw
2007-03-10  9:58       ` Martin Schwidefsky [this message]
2007-03-10  9:58         ` Martin Schwidefsky
2007-03-09 19:40     ` H. Peter Anvin
2007-03-09 20:13       ` Russell King
2007-03-09 20:13         ` Russell King
2007-03-09 20:52         ` H. Peter Anvin
2007-03-09 16:47   ` Benjamin Herrenschmidt
2007-03-09 16:47     ` Benjamin Herrenschmidt
2007-03-09 18:54     ` Andi Kleen
2007-03-09 18:54       ` Andi Kleen
2007-03-10  9:51       ` Martin Schwidefsky
2007-03-10  9:51         ` Martin Schwidefsky
2007-03-09 17:20   ` David Woodhouse
2007-03-09 17:20     ` David Woodhouse
2007-03-19 23:42 ` Andrew Morton
2007-03-19 23:42   ` Andrew Morton
2007-03-20  7:43   ` David Woodhouse
2007-03-20  7:43     ` David Woodhouse
2007-03-20 10:51     ` David Howells
2007-03-20 10:51       ` David Howells
2007-03-20 10:56     ` Russell King
2007-03-20 10:56       ` Russell King
2007-03-21 11:25   ` David Woodhouse
2007-03-21 11:25     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1173520693.7128.17.camel@localhost \
    --to=schwidefsky@de.ibm.com \
    --cc=akpm@osdl.org \
    --cc=andi@firstfloor.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.