All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org,
	David Miller <davem@davemloft.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Stop pmac_zilog from abusing 8250's device numbers.
Date: Wed, 04 Apr 2007 11:13:12 +1000	[thread overview]
Message-ID: <1175649192.30879.19.camel@localhost.localdomain> (raw)
In-Reply-To: <1175645568.10567.42.camel@shinybook.infradead.org>

On Tue, 2007-04-03 at 20:12 -0400, David Woodhouse wrote:
> On Tue, 2007-04-03 at 17:02 -0700, David Miller wrote:
> > Sparc does the same thing, it's a common convention and you really
> > should not break it.
> 
> I thought that argument was lost many years ago. It _used_ to be a
> common convention; we got better.
> 
> > Every powerpc and sparc system out that is using ttyS0 with dynamic
> > minor numbers being allocated.  I really think this should be
> > generalized instead of breaking serial on every powerpc machine out
> > there.
> 
> Nobody's breaking anything. The patch _fixes_ serial, and allows powerpc
> machines to use both z8530 and 8250 ports at the same time; something
> which has been broken for a long time.

It worked before the new serial core, we had a "tweak" in the old 8250
driver to be able to share minors, but that got busted when Russell
rewrote the whole thing. I remember asking him back when he still was
the serial maintainer, and he refused to bring back some sharing of
minors.

Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: David Miller <davem@davemloft.net>,
	flar@allandria.com, paulus@samba.org, linuxppc-dev@ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Stop pmac_zilog from abusing 8250's device numbers.
Date: Wed, 04 Apr 2007 11:13:12 +1000	[thread overview]
Message-ID: <1175649192.30879.19.camel@localhost.localdomain> (raw)
In-Reply-To: <1175645568.10567.42.camel@shinybook.infradead.org>

On Tue, 2007-04-03 at 20:12 -0400, David Woodhouse wrote:
> On Tue, 2007-04-03 at 17:02 -0700, David Miller wrote:
> > Sparc does the same thing, it's a common convention and you really
> > should not break it.
> 
> I thought that argument was lost many years ago. It _used_ to be a
> common convention; we got better.
> 
> > Every powerpc and sparc system out that is using ttyS0 with dynamic
> > minor numbers being allocated.  I really think this should be
> > generalized instead of breaking serial on every powerpc machine out
> > there.
> 
> Nobody's breaking anything. The patch _fixes_ serial, and allows powerpc
> machines to use both z8530 and 8250 ports at the same time; something
> which has been broken for a long time.

It worked before the new serial core, we had a "tweak" in the old 8250
driver to be able to share minors, but that got busted when Russell
rewrote the whole thing. I remember asking him back when he still was
the serial maintainer, and he refused to bring back some sharing of
minors.

Ben.



  parent reply	other threads:[~2007-04-04  1:14 UTC|newest]

Thread overview: 189+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-03 14:25 [PATCH] Stop pmac_zilog from abusing 8250's device numbers David Woodhouse
2007-04-03 20:37 ` Brad Boyer
2007-04-03 22:58   ` David Woodhouse
2007-04-03 23:14 ` Paul Mackerras
2007-04-03 23:14   ` Paul Mackerras
2007-04-03 23:28   ` David Woodhouse
2007-04-03 23:28     ` David Woodhouse
2007-04-03 21:29     ` Brad Boyer
2007-04-03 21:29       ` Brad Boyer
2007-04-03 23:57       ` David Woodhouse
2007-04-03 23:57         ` David Woodhouse
     [not found]         ` <200704032210 02.GA13210@cynthia.pants.nu>
2007-04-03 22:10         ` Brad Boyer
2007-04-03 22:10           ` Brad Boyer
2007-04-04  0:54           ` David Woodhouse
2007-04-04  0:54             ` David Woodhouse
2007-04-03 23:09             ` Brad Boyer
2007-04-03 23:09               ` Brad Boyer
2007-04-04  1:38               ` Alan Cox
2007-04-04  1:38                 ` Alan Cox
2007-04-04  2:05               ` Chris Adams
2007-04-04  2:10               ` Valdis.Kletnieks
2007-04-04  2:10                 ` Valdis.Kletnieks
2007-04-04  1:57                 ` David Lang
2007-04-04  1:57                   ` David Lang
2007-04-04  8:51               ` Russell King
2007-04-04  8:51                 ` Russell King
2007-04-04  9:48                 ` Geert Uytterhoeven
2007-04-04  9:48                   ` Geert Uytterhoeven
2007-04-04 16:09                   ` H. Peter Anvin
2007-04-04 16:09                     ` H. Peter Anvin
2007-04-04 16:22               ` Linas Vepstas
2007-04-04 16:22                 ` Linas Vepstas
2007-04-04 16:34                 ` David Woodhouse
2007-04-04 16:34                   ` David Woodhouse
2007-04-04 17:38                   ` Linas Vepstas
2007-04-04 17:38                     ` Linas Vepstas
2007-04-04  1:16             ` David Miller
2007-04-04  1:16               ` David Miller
2007-04-04  1:28               ` Alan Cox
2007-04-04  1:28                 ` Alan Cox
2007-04-04  1:07                 ` David Lang
2007-04-04  1:07                   ` David Lang
2007-04-04  1:44                   ` Alan Cox
2007-04-04  1:44                     ` Alan Cox
2007-04-04  1:23                     ` David Lang
2007-04-04  1:23                       ` David Lang
2007-04-04  1:32                       ` David Lang
2007-04-04  1:32                         ` David Lang
2007-04-04 16:07                       ` H. Peter Anvin
2007-04-04 16:07                         ` H. Peter Anvin
2007-04-04 17:50                       ` Linas Vepstas
2007-04-04 17:50                         ` Linas Vepstas
2007-04-04  1:50                     ` David Miller
2007-04-04  1:50                       ` David Miller
2007-04-04 11:14                       ` Alan Cox
2007-04-04 11:14                         ` Alan Cox
2007-04-04 12:20                         ` Olivier Galibert
2007-04-04 12:20                           ` Olivier Galibert
2007-04-04  1:48                   ` David Miller
2007-04-04  1:48                     ` David Miller
2007-04-04  3:07                 ` Gerhard Mack
2007-04-04  3:07                   ` Gerhard Mack
2007-04-11 16:30                   ` Benny Amorsen
2007-04-11 16:30                     ` Benny Amorsen
2007-04-12 15:34                     ` Roland Dreier
2007-04-13  2:45                       ` Gerhard Mack
2007-04-13  2:45                         ` Gerhard Mack
2007-04-13  2:24                         ` David Lang
2007-04-13  2:24                           ` David Lang
2007-04-13  8:09                           ` Geert Uytterhoeven
2007-04-13  8:09                             ` Geert Uytterhoeven
2007-04-04  0:02         ` David Miller
2007-04-04  0:02           ` David Miller
2007-04-04  0:12           ` David Woodhouse
2007-04-04  0:12             ` David Woodhouse
2007-04-03 22:14             ` Brad Boyer
2007-04-03 22:14               ` Brad Boyer
2007-04-04  1:13             ` Benjamin Herrenschmidt [this message]
2007-04-04  1:13               ` Benjamin Herrenschmidt
2007-04-04  1:17               ` David Miller
2007-04-04  1:17                 ` David Miller
2007-04-04  1:32                 ` Benjamin Herrenschmidt
2007-04-04  1:32                   ` Benjamin Herrenschmidt
2007-04-04  0:01       ` [PATCH v2] " David Woodhouse
2007-04-04  0:01         ` David Woodhouse
2007-04-04  1:25       ` [PATCH] " Alan Cox
2007-04-04  1:25         ` Alan Cox
2007-04-04  4:20         ` Paul Mackerras
2007-04-04  4:20           ` Paul Mackerras
2007-04-04  5:19           ` David Woodhouse
2007-04-04  5:19             ` David Woodhouse
2007-04-04  5:50             ` David Miller
2007-04-04  5:50               ` David Miller
2007-04-04  7:04               ` Geert Uytterhoeven
2007-04-04  7:04                 ` Geert Uytterhoeven
2007-04-04 13:43                 ` Maciej W. Rozycki
2007-04-04 13:43                   ` Maciej W. Rozycki
2007-04-04  7:52               ` Russell King
2007-04-04  7:52                 ` Russell King
2007-04-04  8:41                 ` David Miller
2007-04-04  8:41                   ` David Miller
2007-04-04  5:53             ` Paul Mackerras
2007-04-04  5:53               ` Paul Mackerras
2007-04-04  6:03               ` David Woodhouse
2007-04-04  6:03                 ` David Woodhouse
2007-04-04  6:31                 ` Paul Mackerras
2007-04-04  6:31                   ` Paul Mackerras
2007-04-04 14:19                   ` [PATCH v3] Stop pmac_zilog from abusing 8250's device numbers; optionally David Woodhouse
2007-04-04 14:19                     ` David Woodhouse
2007-04-04 23:48                     ` Paul Mackerras
2007-04-04 23:48                       ` Paul Mackerras
2007-04-05 12:45                       ` David Woodhouse
2007-04-05 12:45                         ` David Woodhouse
2007-04-05 22:53                         ` Paul Mackerras
2007-04-05 22:53                           ` Paul Mackerras
2007-04-05 22:59                           ` David Woodhouse
2007-04-05 22:59                             ` David Woodhouse
2007-04-05 14:31                     ` Atsushi Nemoto
2007-04-05 14:31                       ` Atsushi Nemoto
2007-04-05 14:47                       ` David Woodhouse
2007-04-05 14:47                         ` David Woodhouse
2007-04-05 15:09                         ` Atsushi Nemoto
2007-04-05 15:09                           ` Atsushi Nemoto
2007-04-05 15:18                           ` David Woodhouse
2007-04-05 15:18                             ` David Woodhouse
2007-04-05 15:49                             ` Atsushi Nemoto
2007-04-05 15:49                               ` Atsushi Nemoto
2007-04-05 15:56                         ` Geert Uytterhoeven
2007-04-05 15:56                           ` Geert Uytterhoeven
2007-04-04  8:12                 ` [PATCH] Stop pmac_zilog from abusing 8250's device numbers David Miller
2007-04-04  8:12                   ` David Miller
2007-04-04  8:38                   ` Russell King
2007-04-04  8:38                     ` Russell King
2007-04-04  8:43                     ` David Miller
2007-04-04  8:43                       ` David Miller
2007-04-04  9:00                       ` Russell King
2007-04-04  9:00                         ` Russell King
2007-04-04 19:58                         ` David Miller
2007-04-04 19:58                           ` David Miller
2007-04-04 12:21                     ` Theodore Tso
2007-04-04 16:10                       ` Russell King
2007-04-04 16:16                       ` H. Peter Anvin
2007-04-04 16:25                         ` Alan Cox
2007-04-04 16:25                           ` Alan Cox
2007-04-04 17:41                         ` Theodore Tso
2007-04-04 17:41                           ` Theodore Tso
2007-04-04 18:15                           ` Russell King
2007-04-04 19:50                             ` David Woodhouse
2007-04-04 19:50                               ` David Woodhouse
2007-04-05  6:05                               ` Paul Mackerras
2007-04-05  6:05                                 ` Paul Mackerras
2007-04-05  8:50                                 ` Russell King
2007-04-05  8:50                                   ` Russell King
2007-04-05 16:15                             ` Olivier Galibert
2007-04-05 21:41                 ` Pavel Machek
2007-04-05 21:41                   ` Pavel Machek
2007-04-03 23:56     ` David Miller
2007-04-03 23:56       ` David Miller
2007-04-04  1:13       ` Benjamin Herrenschmidt
2007-04-04  1:13         ` Benjamin Herrenschmidt
2007-04-04  6:58     ` Paul Mackerras
2007-04-04  6:58       ` Paul Mackerras
2007-04-04 14:16       ` David Woodhouse
2007-04-04 14:16         ` David Woodhouse
2007-04-03 23:55   ` David Miller
2007-04-03 23:55     ` David Miller
2007-04-04  1:19     ` Alan Cox
2007-04-04  1:19       ` Alan Cox
2007-04-04  1:21       ` David Miller
2007-04-04  1:21         ` David Miller
2007-04-04  1:36         ` Alan Cox
2007-04-04  1:36           ` Alan Cox
2007-04-04  1:47           ` David Miller
2007-04-04  1:47             ` David Miller
2007-04-04  7:47         ` Russell King
2007-04-04  7:47           ` Russell King
2007-04-04  9:55           ` Paul Mackerras
2007-04-04  9:55             ` Paul Mackerras
2007-04-04 16:06             ` Russell King
2007-04-04 16:06               ` Russell King
2007-04-04  6:58     ` Geert Uytterhoeven
2007-04-04  6:58       ` Geert Uytterhoeven
2007-08-14 11:49   ` Olaf Hering
2007-08-14 11:49     ` Olaf Hering
2007-08-14 11:53     ` David Woodhouse
2007-08-14 11:53       ` David Woodhouse
2007-08-14 16:24       ` Olaf Hering
2007-08-14 16:24         ` Olaf Hering
2007-04-04  7:55 ` Olaf Hering
     [not found] <fa.RNOVtHsCnerNJiCxv9p57P7pZcA@ifi.uio.no>
     [not found] ` <fa.dSkcKtgkzrihvFnFz6eHJ4FfEqo@ifi.uio.no>
     [not found]   ` <fa.QUe06itDHMey7lWZGdbZCBEo+KI@ifi.uio.no>
     [not found]     ` <fa.Hc/xBcsQlAMlaXgROFi/tmfDmUc@ifi.uio.no>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175649192.30879.19.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.