drivers/video/output.c

drivers/video/output.c

[Dave Jones]

commit 2dec3ba8d872aa3ffbcdb8f6f8a2c0bcd44e9910 puzzles me.

git-bisect just fingered it as responsible for my "backlight doesn't turn on"
suspend/resume regression on the Thinkpad X60.  I think it's lying.

Why?  Because afaict, drivers/video/output.c is never compiled.
That commit adds the driver, but doesn't touch any Makefile, and I
don't see anything obvious in the follow-in commits that would 'enable' it.

Asides from git-bisect failing me again[1], what gives with this file?

	Dave

[1] bisecting suspend regressions _really_ sucks.  Each time I've tried this
I've found 2-3 different ways we regressed along the bisection, making it
hard to say "good" or "bad" when the answer is "bad, but broken differently"

-- 
http://www.codemonkey.org.uk

Re: drivers/video/output.c

[Antonino A. Daplas]

On Tue, 2007-04-17 at 17:37 -0400, Dave Jones wrote:
> commit 2dec3ba8d872aa3ffbcdb8f6f8a2c0bcd44e9910 puzzles me.
> 
> git-bisect just fingered it as responsible for my "backlight doesn't turn on"
> suspend/resume regression on the Thinkpad X60.  I think it's lying.
> 
> Why?  Because afaict, drivers/video/output.c is never compiled.
> That commit adds the driver, but doesn't touch any Makefile, and I
> don't see anything obvious in the follow-in commits that would 'enable' it.
> 
> Asides from git-bisect failing me again[1], what gives with this file?

Correct, it's basically dead code. Even if you compile it, but without
any users, it shouldn't do anything.

BTW, it's completely independent from framebuffer and backlight and I
doubt the commit is the cause of your problem.  

Tony

RE: drivers/video/output.c

[Brown, Len]

>Asides from git-bisect failing me again[1], what gives with this file?

it supports output switching, which didn't make it into 2.6.21 --
probably will be 2.6.22.

-Len

Re: drivers/video/output.c

[Luming Yu]

The user of output sysfs class is coming..
Please check out the acpi video_output patch I just sent to acpi mailing list.
I can't post link here, just because It is not in archive of the ml yet..

On 4/18/07, Brown, Len <len.brown@intel.com> wrote:
> >Asides from git-bisect failing me again[1], what gives with this file?
>
> it supports output switching, which didn't make it into 2.6.21 --
> probably will be 2.6.22.
>
> -Len
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: drivers/video/output.c

[Geert Uytterhoeven]

On Tue, 17 Apr 2007, Dave Jones wrote:
> git-bisect just fingered it as responsible for my "backlight doesn't turn on"
> suspend/resume regression on the Thinkpad X60.  I think it's lying.

Actually I've seeing git bisect lying on me, too. I retried a few times
(fortunately it didn't require rebooting, as the problem was just a compile
error) to make sure I made no mistakes in answering, but I always ended up
with the wrong commit.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds