From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 7/7] MPIC U3/U4 MSI backend
Date: Wed, 09 May 2007 09:43:14 +1000 [thread overview]
Message-ID: <1178667794.14928.126.camel@localhost.localdomain> (raw)
In-Reply-To: <1178614502.18162.34.camel@johannes.berg>
On Tue, 2007-05-08 at 10:55 +0200, Johannes Berg wrote:
> On Tue, 2007-05-08 at 12:58 +1000, Michael Ellerman wrote:
> > MPIC U3/U4 MSI backend. Based on code from Segher, heavily hacked by me.
> > This only deals with MSI on U3/U4 MPICs, aka. CPC 9x5.
> >
> > If we find a U3/U4 then we enable this backend, ie. take over the ppc_md
> > MSI hooks. We might need more elaborate logic in future to decide which
> > backend is enabled.
> >
> > We need our own irq_chip so that we can do MSI masking/unmasking on
> > the device itself. We also need to mask explicitly on shutdown to make
> > sure we don't get bitten by lazy-disable semantics.
>
> How badly will this clash with my patch that implements suspend/resume
> for mpic, and will I need to do more suspend/resume for this?
Maybe... for now, don't bother, we'll do fixups later on. I think your
patch can be done differently and more simply. I don't think we need to
save/restore all this state, we can proably reconfigure everything with
what we have.
Ben.
next prev parent reply other threads:[~2007-05-08 23:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 2:58 [PATCH 1/7] Rip out the existing powerpc msi stubs Michael Ellerman
2007-05-08 2:58 ` [PATCH 2/7] Powerpc MSI infrastructure Michael Ellerman
2007-05-08 2:58 ` [PATCH 4/7] Tell Phyp we support MSI Michael Ellerman
2007-05-08 2:58 ` [PATCH 3/7] RTAS MSI implementation Michael Ellerman
2007-05-08 2:58 ` [PATCH 6/7] MPIC MSI allocator Michael Ellerman
2007-05-08 2:58 ` [PATCH 5/7] Enable MSI mappings for MPIC Michael Ellerman
2007-05-08 2:58 ` [PATCH 7/7] MPIC U3/U4 MSI backend Michael Ellerman
2007-05-08 8:55 ` Johannes Berg
2007-05-08 9:04 ` Johannes Berg
2007-05-08 23:43 ` Benjamin Herrenschmidt [this message]
2007-05-12 8:28 ` Johannes Berg
2007-05-12 9:06 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178667794.14928.126.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.