All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 7/7] MPIC U3/U4 MSI backend
Date: Sat, 12 May 2007 19:06:35 +1000	[thread overview]
Message-ID: <1178960796.32247.38.camel@localhost.localdomain> (raw)
In-Reply-To: <1178958505.2647.5.camel@johannes.berg>

On Sat, 2007-05-12 at 10:28 +0200, Johannes Berg wrote:
> > +	pr_debug("u3msi: allocated virq 0x%x (hw 0x%lx) at address 0x%lx\n",
> > +		 virq, virq_to_hw(virq), addr);
> 
> I get
> arch/powerpc/sysdev/mpic_u3msi.c: In function ‘u3msi_compose_msi_msg’:
> arch/powerpc/sysdev/mpic_u3msi.c:121: warning: format ‘%lx’ expects type
> ‘long unsigned int’, but argument 4 has type ‘u64’
> 
> when building this on ppc32 (I wonder if that even makes sense anyway
> but Kconfig allowed me to select MSI)

Hrm... we should definitely make the U3 MSI bits 64 bits only for now at
least.

Ben.

      reply	other threads:[~2007-05-12  9:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-08  2:58 [PATCH 1/7] Rip out the existing powerpc msi stubs Michael Ellerman
2007-05-08  2:58 ` [PATCH 2/7] Powerpc MSI infrastructure Michael Ellerman
2007-05-08  2:58 ` [PATCH 4/7] Tell Phyp we support MSI Michael Ellerman
2007-05-08  2:58 ` [PATCH 3/7] RTAS MSI implementation Michael Ellerman
2007-05-08  2:58 ` [PATCH 5/7] Enable MSI mappings for MPIC Michael Ellerman
2007-05-08  2:58 ` [PATCH 6/7] MPIC MSI allocator Michael Ellerman
2007-05-08  2:58 ` [PATCH 7/7] MPIC U3/U4 MSI backend Michael Ellerman
2007-05-08  8:55   ` Johannes Berg
2007-05-08  9:04     ` Johannes Berg
2007-05-08 23:43     ` Benjamin Herrenschmidt
2007-05-12  8:28   ` Johannes Berg
2007-05-12  9:06     ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1178960796.32247.38.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=johannes@sipsolutions.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.