From: Daniel Walker <dwalker@mvista.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Gregory Haskins <ghaskins@novell.com>,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RT: Add priority-queuing and priority-inheritance to workqueue infrastructure
Date: Wed, 01 Aug 2007 11:29:54 -0700 [thread overview]
Message-ID: <1185992994.2636.142.camel@imap.mvista.com> (raw)
In-Reply-To: <20070801181253.GA90@tv-sign.ru>
On Wed, 2007-08-01 at 22:12 +0400, Oleg Nesterov wrote:
> And I personally think it is not very useful, even if it was correct.
> You can create your own workqueue and change the priority of cwq->thread.
This change is more dynamic than than just setting a single priority ..
There was some other work going on around this, so it's not totally
clear what the benefits are ..
> > > @@ -168,7 +171,7 @@ int fastcall queue_work(struct workqueue
> > > int ret = 0, cpu = raw_smp_processor_id();
> > >
> > > if (!test_and_set_bit(WORK_STRUCT_PENDING, work_data_bits(work))) {
> > > - BUG_ON(!list_empty(&work->entry));
> > > + BUG_ON(!plist_node_empty(&work->entry));
> > > __queue_work(wq_per_cpu(wq, cpu), work);
> > > ret = 1;
>
> Side note, looks like you use some strange kernel. This raw_smp_processor_id()
> above is wrong.
As the topic suggests , it's a Real Time kernel .. I can give you a link
where to download it if you want.
Daniel
next prev parent reply other threads:[~2007-08-01 18:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 0:26 [PATCH] RT: Add priority-queuing and priority-inheritance to workqueue infrastructure Gregory Haskins
2007-08-01 3:52 ` Daniel Walker
2007-08-01 11:59 ` Gregory Haskins
2007-08-01 15:10 ` Daniel Walker
2007-08-01 15:19 ` Gregory Haskins
2007-08-01 15:55 ` Daniel Walker
2007-08-01 17:32 ` Gregory Haskins
2007-08-01 21:48 ` Esben Nielsen
2007-08-01 17:01 ` Peter Zijlstra
2007-08-01 17:10 ` Daniel Walker
2007-08-01 18:26 ` Oleg Nesterov
2007-08-01 18:39 ` Daniel Walker
2007-08-01 20:25 ` Oleg Nesterov
2007-08-01 18:12 ` Oleg Nesterov
2007-08-01 18:29 ` Daniel Walker [this message]
2007-08-01 20:18 ` Oleg Nesterov
2007-08-01 20:32 ` Oleg Nesterov
2007-08-01 20:43 ` Daniel Walker
2007-08-01 20:34 ` Daniel Walker
2007-08-01 20:50 ` Oleg Nesterov
2007-08-01 21:02 ` Daniel Walker
2007-08-01 21:13 ` Gregory Haskins
2007-08-01 21:34 ` Oleg Nesterov
2007-08-01 21:59 ` Gregory Haskins
2007-08-01 22:22 ` Oleg Nesterov
2007-08-01 23:53 ` Gregory Haskins
2007-08-02 19:50 ` Oleg Nesterov
2007-08-06 11:35 ` Gregory Haskins
2007-08-06 14:26 ` Oleg Nesterov
2007-08-06 14:57 ` Gregory Haskins
2007-08-06 15:36 ` Oleg Nesterov
2007-08-06 15:50 ` Gregory Haskins
2007-08-06 16:50 ` Oleg Nesterov
2007-08-06 16:57 ` Gregory Haskins
2007-08-06 11:49 ` Ingo Molnar
2007-08-06 13:18 ` Oleg Nesterov
2007-08-06 13:29 ` Peter Zijlstra
2007-08-06 13:32 ` Peter Zijlstra
2007-08-06 14:45 ` Oleg Nesterov
2007-08-06 14:52 ` Peter Zijlstra
2007-08-06 16:40 ` Oleg Nesterov
2007-08-06 15:04 ` Gregory Haskins
2007-08-06 15:38 ` Oleg Nesterov
2007-08-06 19:33 ` Oleg Nesterov
2007-08-06 19:37 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185992994.2636.142.camel@imap.mvista.com \
--to=dwalker@mvista.com \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.