From: Jim Paris <jim-XrPbb/hENzg@public.gmane.org>
To: Uri Lublin <uril-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: Jim Paris <jim-XrPbb/hENzg@public.gmane.org>
Subject: [PATCH 3/3] qemu: reset buffer pointers after CR/LF
Date: Wed, 8 Aug 2007 16:22:49 -0400 [thread overview]
Message-ID: <11866045691503-git-send-email-jim@jtan.com> (raw)
In-Reply-To: <1186604569652-git-send-email-jim-XrPbb/hENzg@public.gmane.org>
If readline_handle_byte() is sent both a CR and LF, and
readline_start() is not called after the first CR, then the LF will
cause the same command to be executed a second time. Fix this by
explicitly resetting the buffer pointer when it is processed.
Signed-off-by: Jim Paris <jim-XrPbb/hENzg@public.gmane.org>
---
This should probably get pushed upstream too.
qemu/readline.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/qemu/readline.c b/qemu/readline.c
index cbe33db..bde3342 100644
--- a/qemu/readline.c
+++ b/qemu/readline.c
@@ -335,6 +335,8 @@ void readline_handle_byte(int ch)
if (!term_is_password)
term_hist_add(term_cmd_buf);
term_printf("\n");
+ term_cmd_buf_index = 0;
+ term_cmd_buf_size = 0;
/* NOTE: readline_start can be called here */
term_readline_func(term_readline_opaque, term_cmd_buf);
break;
--
1.5.3.GIT
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-08-08 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 20:22 migration with exec giving truncated images Jim Paris
[not found] ` <1186604569626-git-send-email-jim-XrPbb/hENzg@public.gmane.org>
2007-08-08 20:22 ` [PATCH 1/3] qemu: fix freed pointer dereference Jim Paris
[not found] ` <11866045692122-git-send-email-jim-XrPbb/hENzg@public.gmane.org>
2007-08-08 20:22 ` [PATCH 2/3] qemu: don't start a new migration if one is already in progress Jim Paris
[not found] ` <1186604569652-git-send-email-jim-XrPbb/hENzg@public.gmane.org>
2007-08-08 20:22 ` Jim Paris [this message]
2007-08-09 21:42 ` [PATCH 1/3] qemu: fix freed pointer dereference Avi Kivity
2007-08-09 12:24 ` migration with exec giving truncated images Uri Lublin
[not found] ` <46BB0760.80405-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-14 3:56 ` Jim Paris
[not found] ` <20070814035659.GA10726-lSbMZ+N7itA@public.gmane.org>
2007-08-14 4:49 ` Jim Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11866045691503-git-send-email-jim@jtan.com \
--to=jim-xrpbb/henzg@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=uril-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.