All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Paris <jim-XrPbb/hENzg@public.gmane.org>
To: Uri Lublin <uril-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
	kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: Jim Paris <jim-XrPbb/hENzg@public.gmane.org>
Subject: [PATCH 2/3] qemu: don't start a new migration if one is already in progress
Date: Wed,  8 Aug 2007 16:22:48 -0400	[thread overview]
Message-ID: <1186604569652-git-send-email-jim@jtan.com> (raw)
In-Reply-To: <11866045692122-git-send-email-jim-XrPbb/hENzg@public.gmane.org>


Signed-off-by: Jim Paris <jim-XrPbb/hENzg@public.gmane.org>
---

Having two migrations run simultaneously was causing my crashes.
The command was sent twice because of a bug in the readline routines,
but adding a check here as well seems like a good idea.

 qemu/migration.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/qemu/migration.c b/qemu/migration.c
index 4d7aa01..96b0c2f 100644
--- a/qemu/migration.c
+++ b/qemu/migration.c
@@ -973,6 +973,12 @@ int migrate_incoming(const char *device)
 void do_migrate(int detach, const char *uri)
 {
     const char *ptr;
+    MigrationState *s = current_migration;
+
+    if (s) {
+	term_printf("Migration already active\n");
+	return;
+    }
 
     status = MIG_STAT_INVALID_PARAMS;
     if (strstart(uri, "exec:", &ptr)) {
-- 
1.5.3.GIT


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

  parent reply	other threads:[~2007-08-08 20:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-08 20:22 migration with exec giving truncated images Jim Paris
     [not found] ` <1186604569626-git-send-email-jim-XrPbb/hENzg@public.gmane.org>
2007-08-08 20:22   ` [PATCH 1/3] qemu: fix freed pointer dereference Jim Paris
     [not found]     ` <11866045692122-git-send-email-jim-XrPbb/hENzg@public.gmane.org>
2007-08-08 20:22       ` Jim Paris [this message]
     [not found]         ` <1186604569652-git-send-email-jim-XrPbb/hENzg@public.gmane.org>
2007-08-08 20:22           ` [PATCH 3/3] qemu: reset buffer pointers after CR/LF Jim Paris
2007-08-09 21:42       ` [PATCH 1/3] qemu: fix freed pointer dereference Avi Kivity
2007-08-09 12:24   ` migration with exec giving truncated images Uri Lublin
     [not found]     ` <46BB0760.80405-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-14  3:56       ` Jim Paris
     [not found]         ` <20070814035659.GA10726-lSbMZ+N7itA@public.gmane.org>
2007-08-14  4:49           ` Jim Paris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1186604569652-git-send-email-jim@jtan.com \
    --to=jim-xrpbb/henzg@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=uril-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.