All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Paris <jim-XrPbb/hENzg@public.gmane.org>
To: Uri Lublin <uril-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: migration with exec giving truncated images
Date: Mon, 13 Aug 2007 23:56:59 -0400	[thread overview]
Message-ID: <20070814035659.GA10726@jim.sh> (raw)
In-Reply-To: <46BB0760.80405-atKUWr5tajBWk0Htik3J/w@public.gmane.org>

Uri Lublin wrote:
> There is still the mystery of different file sizes for different 
> migration-exec commands, all files are "valid saved image".
> It seems to me that some unmodified pages are being marked as dirty, and 
> are being saved twice (and later loaded twice).
> I'm still chasing that.

Hi Uri,

I looked into this a bit more and it seems that a big piece of
migration.c is missing or broken.

In migrate_write_buffer, it calls migrate_check_convergence, which
returns TRUE if the migration is "almost" complete (dirty pages < 50,
or too many iterations through memory).  At that point, it then calls
migrate_finish -- which finishes writing the current page, but never
actually writes the remaining 50 pages (!)  Am I missing something?

-jim



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

  parent reply	other threads:[~2007-08-14  3:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-08 20:22 migration with exec giving truncated images Jim Paris
     [not found] ` <1186604569626-git-send-email-jim-XrPbb/hENzg@public.gmane.org>
2007-08-08 20:22   ` [PATCH 1/3] qemu: fix freed pointer dereference Jim Paris
     [not found]     ` <11866045692122-git-send-email-jim-XrPbb/hENzg@public.gmane.org>
2007-08-08 20:22       ` [PATCH 2/3] qemu: don't start a new migration if one is already in progress Jim Paris
     [not found]         ` <1186604569652-git-send-email-jim-XrPbb/hENzg@public.gmane.org>
2007-08-08 20:22           ` [PATCH 3/3] qemu: reset buffer pointers after CR/LF Jim Paris
2007-08-09 21:42       ` [PATCH 1/3] qemu: fix freed pointer dereference Avi Kivity
2007-08-09 12:24   ` migration with exec giving truncated images Uri Lublin
     [not found]     ` <46BB0760.80405-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-14  3:56       ` Jim Paris [this message]
     [not found]         ` <20070814035659.GA10726-lSbMZ+N7itA@public.gmane.org>
2007-08-14  4:49           ` Jim Paris
  -- strict thread matches above, loose matches on Subject: below --
2007-08-02 21:02 Jim Paris
     [not found] ` <20070802210226.GA29753-lSbMZ+N7itA@public.gmane.org>
2007-08-03 18:23   ` Jim Paris
     [not found]     ` <20070803182333.GA15267-lSbMZ+N7itA@public.gmane.org>
2007-08-07 18:28       ` Jim Paris
     [not found]         ` <20070807182826.GA30737-lSbMZ+N7itA@public.gmane.org>
2007-08-08  9:14           ` Uri Lublin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070814035659.GA10726@jim.sh \
    --to=jim-xrpbb/henzg@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=uril-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.