* convert #include "linux/..." to #include <linux/...> [PATCH]s
@ 2007-08-19 22:17 ` Joe Perches
0 siblings, 0 replies; 14+ messages in thread
From: Joe Perches @ 2007-08-19 22:17 UTC (permalink / raw)
To: kernel-janitors, linux-kernel; +Cc: Andy Whitcroft
There are several files that:
#include "linux/file" not #include <linux/file>
#include "asm/file" not #include <asm/file>
Here's a little script that converts them:
egrep -i -r -l --include=*.[ch] \
"^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \
| xargs sed -i -e 's/^[[:space:]]*#[[:space:]]*include[[:space:]]*"\(linux\|asm\)\/\(.*\)"/#include <\1\/\2>/g'
Maybe a similar check could be added to checkpatch.pl
^ permalink raw reply [flat|nested] 14+ messages in thread
* convert #include "linux/..." to #include <linux/...> [PATCH]s follow
@ 2007-08-19 22:17 ` Joe Perches
0 siblings, 0 replies; 14+ messages in thread
From: Joe Perches @ 2007-08-19 22:17 UTC (permalink / raw)
To: kernel-janitors, linux-kernel; +Cc: Andy Whitcroft
There are several files that:
#include "linux/file" not #include <linux/file>
#include "asm/file" not #include <asm/file>
Here's a little script that converts them:
egrep -i -r -l --include=*.[ch] \
"^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \
| xargs sed -i -e 's/^[[:space:]]*#[[:space:]]*include[[:space:]]*"\(linux\|asm\)\/\(.*\)"/#include <\1\/\2>/g'
Maybe a similar check could be added to checkpatch.pl
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow
2007-08-19 22:17 ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Joe Perches
@ 2007-08-19 22:19 ` Jesper Juhl
-1 siblings, 0 replies; 14+ messages in thread
From: Jesper Juhl @ 2007-08-19 22:19 UTC (permalink / raw)
To: Joe Perches; +Cc: kernel-janitors, linux-kernel, Andy Whitcroft
On 20/08/07, Joe Perches <joe@perches.com> wrote:
> There are several files that:
>
> #include "linux/file" not #include <linux/file>
> #include "asm/file" not #include <asm/file>
>
> Here's a little script that converts them:
>
If you've actually checked that such conversions are correct and work
fine, how about a patch (or patches)?
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: convert #include "linux/..." to #include <linux/...> [PATCH]s
2007-08-19 22:17 ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Joe Perches
@ 2007-08-19 22:33 ` Jan Engelhardt
-1 siblings, 0 replies; 14+ messages in thread
From: Jan Engelhardt @ 2007-08-19 22:33 UTC (permalink / raw)
To: Joe Perches; +Cc: kernel-janitors, linux-kernel, Andy Whitcroft
On Aug 19 2007 15:17, Joe Perches wrote:
>There are several files that:
>
>#include "linux/file" not #include <linux/file>
>#include "asm/file" not #include <asm/file>
Not only that. All directories in include should be checked against
(e.g. <net/*>)
Jan
--
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow
@ 2007-08-19 22:33 ` Jan Engelhardt
0 siblings, 0 replies; 14+ messages in thread
From: Jan Engelhardt @ 2007-08-19 22:33 UTC (permalink / raw)
To: Joe Perches; +Cc: kernel-janitors, linux-kernel, Andy Whitcroft
On Aug 19 2007 15:17, Joe Perches wrote:
>There are several files that:
>
>#include "linux/file" not #include <linux/file>
>#include "asm/file" not #include <asm/file>
Not only that. All directories in include should be checked against
(e.g. <net/*>)
Jan
--
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow
2007-08-19 22:33 ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Jan Engelhardt
@ 2007-08-19 22:44 ` Al Viro
-1 siblings, 0 replies; 14+ messages in thread
From: Al Viro @ 2007-08-19 22:44 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Joe Perches, kernel-janitors, linux-kernel, Andy Whitcroft
On Mon, Aug 20, 2007 at 12:33:21AM +0200, Jan Engelhardt wrote:
>
> On Aug 19 2007 15:17, Joe Perches wrote:
> >There are several files that:
> >
> >#include "linux/file" not #include <linux/file>
> >#include "asm/file" not #include <asm/file>
>
> Not only that. All directories in include should be checked against
> (e.g. <net/*>)
Except that some instances are legitimate (e.g. there was a bunch in
arch/um, IIRC)...
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow
@ 2007-08-19 22:44 ` Al Viro
0 siblings, 0 replies; 14+ messages in thread
From: Al Viro @ 2007-08-19 22:44 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Joe Perches, kernel-janitors, linux-kernel, Andy Whitcroft
On Mon, Aug 20, 2007 at 12:33:21AM +0200, Jan Engelhardt wrote:
>
> On Aug 19 2007 15:17, Joe Perches wrote:
> >There are several files that:
> >
> >#include "linux/file" not #include <linux/file>
> >#include "asm/file" not #include <asm/file>
>
> Not only that. All directories in include should be checked against
> (e.g. <net/*>)
Except that some instances are legitimate (e.g. there was a bunch in
arch/um, IIRC)...
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: convert #include "linux/..." to #include <linux/...> [PATCH]s
2007-08-19 22:44 ` Al Viro
@ 2007-08-19 22:49 ` Joe Perches
-1 siblings, 0 replies; 14+ messages in thread
From: Joe Perches @ 2007-08-19 22:49 UTC (permalink / raw)
To: Al Viro; +Cc: Jan Engelhardt, kernel-janitors, linux-kernel, Andy Whitcroft
On Sun, 2007-08-19 at 23:44 +0100, Al Viro wrote:
> Except that some instances are legitimate (e.g. there was a bunch in
> arch/um, IIRC)...
I guess it's a good thing that vger seems to have rejected
that 140KB patch I sent against arch/um and include/asm-um.
cheers, Joe
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow
@ 2007-08-19 22:49 ` Joe Perches
0 siblings, 0 replies; 14+ messages in thread
From: Joe Perches @ 2007-08-19 22:49 UTC (permalink / raw)
To: Al Viro; +Cc: Jan Engelhardt, kernel-janitors, linux-kernel, Andy Whitcroft
On Sun, 2007-08-19 at 23:44 +0100, Al Viro wrote:
> Except that some instances are legitimate (e.g. there was a bunch in
> arch/um, IIRC)...
I guess it's a good thing that vger seems to have rejected
that 140KB patch I sent against arch/um and include/asm-um.
cheers, Joe
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow
2007-08-19 22:49 ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Joe Perches
@ 2007-08-19 22:58 ` Al Viro
-1 siblings, 0 replies; 14+ messages in thread
From: Al Viro @ 2007-08-19 22:58 UTC (permalink / raw)
To: Joe Perches; +Cc: Jan Engelhardt, kernel-janitors, linux-kernel, Andy Whitcroft
On Sun, Aug 19, 2007 at 03:49:16PM -0700, Joe Perches wrote:
> On Sun, 2007-08-19 at 23:44 +0100, Al Viro wrote:
> > Except that some instances are legitimate (e.g. there was a bunch in
> > arch/um, IIRC)...
>
> I guess it's a good thing that vger seems to have rejected
> that 140KB patch I sent against arch/um and include/asm-um.
It would be a better thing if you
* did builds of the patched trees (allmodconfig for uml/i386 and
uml/amd64 in this case)
* figured out that one can send a reference to branch in git tree
(with summary/shortlog/diffstat) using somewhat less than 140KB...
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow
@ 2007-08-19 22:58 ` Al Viro
0 siblings, 0 replies; 14+ messages in thread
From: Al Viro @ 2007-08-19 22:58 UTC (permalink / raw)
To: Joe Perches; +Cc: Jan Engelhardt, kernel-janitors, linux-kernel, Andy Whitcroft
On Sun, Aug 19, 2007 at 03:49:16PM -0700, Joe Perches wrote:
> On Sun, 2007-08-19 at 23:44 +0100, Al Viro wrote:
> > Except that some instances are legitimate (e.g. there was a bunch in
> > arch/um, IIRC)...
>
> I guess it's a good thing that vger seems to have rejected
> that 140KB patch I sent against arch/um and include/asm-um.
It would be a better thing if you
* did builds of the patched trees (allmodconfig for uml/i386 and
uml/amd64 in this case)
* figured out that one can send a reference to branch in git tree
(with summary/shortlog/diffstat) using somewhat less than 140KB...
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: convert #include "linux/..." to #include <linux/...> [PATCH]s
2007-08-19 22:33 ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Jan Engelhardt
@ 2007-08-19 23:05 ` Joe Perches
-1 siblings, 0 replies; 14+ messages in thread
From: Joe Perches @ 2007-08-19 23:05 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: kernel-janitors, linux-kernel, Andy Whitcroft
On Mon, 2007-08-20 at 00:33 +0200, Jan Engelhardt wrote:
> Not only that. All directories in include should be checked against
> (e.g. <net/*>)
Should any file in include/ have a line like:
#include "[path/]file"
Shouldn't these all be
#include <path/file>
?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow
@ 2007-08-19 23:05 ` Joe Perches
0 siblings, 0 replies; 14+ messages in thread
From: Joe Perches @ 2007-08-19 23:05 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: kernel-janitors, linux-kernel, Andy Whitcroft
On Mon, 2007-08-20 at 00:33 +0200, Jan Engelhardt wrote:
> Not only that. All directories in include should be checked against
> (e.g. <net/*>)
Should any file in include/ have a line like:
#include "[path/]file"
Shouldn't these all be
#include <path/file>
?
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2007-08-19 23:05 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-19 22:17 convert #include "linux/..." to #include <linux/...> [PATCH]s Joe Perches
2007-08-19 22:17 ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Joe Perches
2007-08-19 22:19 ` Jesper Juhl
2007-08-19 22:19 ` Jesper Juhl
2007-08-19 22:33 ` convert #include "linux/..." to #include <linux/...> [PATCH]s Jan Engelhardt
2007-08-19 22:33 ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Jan Engelhardt
2007-08-19 22:44 ` Al Viro
2007-08-19 22:44 ` Al Viro
2007-08-19 22:49 ` convert #include "linux/..." to #include <linux/...> [PATCH]s Joe Perches
2007-08-19 22:49 ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Joe Perches
2007-08-19 22:58 ` Al Viro
2007-08-19 22:58 ` Al Viro
2007-08-19 23:05 ` convert #include "linux/..." to #include <linux/...> [PATCH]s Joe Perches
2007-08-19 23:05 ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.