From: Dave Hansen <haveblue@us.ibm.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.osdl.org>,
Paul Menage <menage@google.com>,
Linux MM Mailing List <linux-mm@kvack.org>,
David Rientjes <rientjes@google.com>
Subject: Re: [-mm PATCH] Memory controller improve user interface (v3)
Date: Tue, 04 Sep 2007 12:03:13 -0700 [thread overview]
Message-ID: <1188932593.28903.357.camel@localhost> (raw)
In-Reply-To: <20070902105021.3737.31251.sendpatchset@balbir-laptop>
On Sun, 2007-09-02 at 16:20 +0530, Balbir Singh wrote:
>
> +Setting a limit to a number that is not a multiple of page size causes
> +rounding up of the value. The user must check back to see (by reading
> +memory.limit_in_bytes), to check for differences between desired values and
> +committed values. Currently, all accounting is done in multiples of PAGE_SIZE
I wonder if we can say this in a bit more generic fashion.
A successful write to this file does not guarantee a successful
set of this limit to the value written into the file. This can
be due to a number of factors, such as rounding up to page
boundaries or the total availability of memory on the system.
The user is required to re-read this file after a write to
guarantee the value committed by the kernel.
This keeps a user from saying "I page aligned the value I stuck in
there, no I don't have to check it."
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.osdl.org>,
Paul Menage <menage@google.com>,
Linux MM Mailing List <linux-mm@kvack.org>,
David Rientjes <rientjes@google.com>
Subject: Re: [-mm PATCH] Memory controller improve user interface (v3)
Date: Tue, 04 Sep 2007 12:03:13 -0700 [thread overview]
Message-ID: <1188932593.28903.357.camel@localhost> (raw)
In-Reply-To: <20070902105021.3737.31251.sendpatchset@balbir-laptop>
On Sun, 2007-09-02 at 16:20 +0530, Balbir Singh wrote:
>
> +Setting a limit to a number that is not a multiple of page size causes
> +rounding up of the value. The user must check back to see (by reading
> +memory.limit_in_bytes), to check for differences between desired values and
> +committed values. Currently, all accounting is done in multiples of PAGE_SIZE
I wonder if we can say this in a bit more generic fashion.
A successful write to this file does not guarantee a successful
set of this limit to the value written into the file. This can
be due to a number of factors, such as rounding up to page
boundaries or the total availability of memory on the system.
The user is required to re-read this file after a write to
guarantee the value committed by the kernel.
This keeps a user from saying "I page aligned the value I stuck in
there, no I don't have to check it."
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-09-04 19:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-02 10:50 [-mm PATCH] Memory controller improve user interface (v3) Balbir Singh
2007-09-02 10:50 ` Balbir Singh
2007-09-03 4:53 ` Paul Menage
2007-09-03 4:53 ` Paul Menage
[not found] ` <6599ad830709022153g1720bcedsb61d7cf7a783bd3f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-09-03 19:45 ` Balbir Singh
2007-09-03 19:45 ` Balbir Singh
2007-09-03 19:45 ` Balbir Singh
2007-09-03 19:49 ` Balbir Singh
2007-09-03 19:49 ` Balbir Singh
2007-09-04 7:19 ` Paul Menage
2007-09-04 7:19 ` Paul Menage
2007-09-04 7:28 ` Balbir Singh
2007-09-04 7:28 ` Balbir Singh
2007-09-05 16:05 ` Balbir Singh
2007-09-05 16:05 ` Balbir Singh
2007-09-03 19:55 ` Balbir Singh
2007-09-03 19:55 ` Balbir Singh
2007-09-04 19:03 ` Dave Hansen [this message]
2007-09-04 19:03 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188932593.28903.357.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.