All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Containers <containers@lists.osdl.org>,
	Linux MM Mailing List <linux-mm@kvack.org>,
	David Rientjes <rientjes@google.com>,
	Dave Hansen <haveblue@us.ibm.com>
Subject: Re: [-mm PATCH] Memory controller improve user interface (v3)
Date: Mon, 03 Sep 2007 20:49:23 +0100	[thread overview]
Message-ID: <46DC6543.3000607@linux.vnet.ibm.com> (raw)
In-Reply-To: <6599ad830709022153g1720bcedsb61d7cf7a783bd3f@mail.gmail.com>

Paul Menage wrote:
> On 9/2/07, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>> -       s += sprintf(s, "%lu\n", *val);
>> +       if (read_strategy)
>> +               s += read_strategy(*val, s);
>> +       else
>> +               s += sprintf(s, "%lu\n", *val);
> 
> This would be better as %llu
> 

Hi, Paul,

This does not need fixing, since the other counters like failcnt are
still unsigned long

>> +               tmp = simple_strtoul(buf, &end, 10);
> 
> and this as simple_strtoull()
> 


Will do, thanks!



-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Containers <containers@lists.osdl.org>,
	Linux MM Mailing List <linux-mm@kvack.org>,
	David Rientjes <rientjes@google.com>,
	Dave Hansen <haveblue@us.ibm.com>
Subject: Re: [-mm PATCH] Memory controller improve user interface (v3)
Date: Mon, 03 Sep 2007 20:49:23 +0100	[thread overview]
Message-ID: <46DC6543.3000607@linux.vnet.ibm.com> (raw)
In-Reply-To: <6599ad830709022153g1720bcedsb61d7cf7a783bd3f@mail.gmail.com>

Paul Menage wrote:
> On 9/2/07, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>> -       s += sprintf(s, "%lu\n", *val);
>> +       if (read_strategy)
>> +               s += read_strategy(*val, s);
>> +       else
>> +               s += sprintf(s, "%lu\n", *val);
> 
> This would be better as %llu
> 

Hi, Paul,

This does not need fixing, since the other counters like failcnt are
still unsigned long

>> +               tmp = simple_strtoul(buf, &end, 10);
> 
> and this as simple_strtoull()
> 


Will do, thanks!



-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2007-09-03 19:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-02 10:50 [-mm PATCH] Memory controller improve user interface (v3) Balbir Singh
2007-09-02 10:50 ` Balbir Singh
2007-09-03  4:53 ` Paul Menage
2007-09-03  4:53   ` Paul Menage
     [not found]   ` <6599ad830709022153g1720bcedsb61d7cf7a783bd3f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-09-03 19:45     ` Balbir Singh
2007-09-03 19:45       ` Balbir Singh
2007-09-03 19:45       ` Balbir Singh
2007-09-03 19:49   ` Balbir Singh [this message]
2007-09-03 19:49     ` Balbir Singh
2007-09-04  7:19     ` Paul Menage
2007-09-04  7:19       ` Paul Menage
2007-09-04  7:28       ` Balbir Singh
2007-09-04  7:28         ` Balbir Singh
2007-09-05 16:05       ` Balbir Singh
2007-09-05 16:05         ` Balbir Singh
2007-09-03 19:55   ` Balbir Singh
2007-09-03 19:55     ` Balbir Singh
2007-09-04 19:03 ` Dave Hansen
2007-09-04 19:03   ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46DC6543.3000607@linux.vnet.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.osdl.org \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=menage@google.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.