From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Manfred Spraul <manfred@colorfullife.com>,
Jeff Garzik <jgarzik@pobox.com>,
Ayaz Abdulla <aabdulla@nvidia.com>,
nedev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: MSI interrupts and disable_irq
Date: Mon, 15 Oct 2007 09:36:12 +1000 [thread overview]
Message-ID: <1192404972.7014.0.camel@pasglop> (raw)
In-Reply-To: <86802c440710141615g60fb9775oba590deb1a9fabde@mail.gmail.com>
On Sun, 2007-10-14 at 16:15 -0700, Yinghai Lu wrote:
> On 10/14/07, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > On Sun, 2007-10-14 at 09:15 +0200, Manfred Spraul wrote:
> > > Yinghai Lu wrote:
> > > > On 10/13/07, Manfred Spraul <manfred@colorfullife.com> wrote:
> > > >
> > > >> Someone around with a MSI capable board? The forcedeth driver does
> > > >> dev->irq = pci_dev->irq
> > > >> in nv_probe(), especially before pci_enable_msi().
> > > >> Does pci_enable_msi() change pci_dev->irq? Then we would disable the
> > > >> wrong interrupt....
> > > >>
> > > >
> > > > the request_irq==>setup_irq will make dev->irq = pci_dev->irq.
> > > >
> > > >
> > > Where is that?
> > > Otherwise I would propose the attached patch. My board is not
> > > MSI-capable, thus I can't test it myself.
> >
> > Why not just copy pcidev->irq to dev->irq once ?
>
> it seems e1000 is using np->pci_dev->irq directly too.
Heh, allright, doesn't matter, I was just proposing to avoid one more
indirection :-)
Ben.
next prev parent reply other threads:[~2007-10-14 23:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 20:42 MSI interrupts and disable_irq Ayaz Abdulla
2007-09-29 2:47 ` Jeff Garzik
2007-09-29 3:08 ` Stephen Hemminger
2007-10-05 22:12 ` Eric W. Biederman
2007-10-06 6:23 ` Yinghai Lu
2007-10-06 17:43 ` Yinghai Lu
2007-10-06 17:59 ` Jeff Garzik
2007-10-07 16:54 ` Manfred Spraul
2007-10-13 9:30 ` Manfred Spraul
2007-10-14 5:59 ` Yinghai Lu
2007-10-14 7:15 ` Manfred Spraul
2007-10-14 19:55 ` Yinghai Lu
2007-10-14 21:47 ` Benjamin Herrenschmidt
2007-10-14 23:15 ` Yinghai Lu
2007-10-14 23:36 ` Benjamin Herrenschmidt [this message]
2007-10-15 22:17 ` Jeff Garzik
2007-10-16 17:23 ` Yinghai Lu
2007-10-16 17:39 ` Jeff Garzik
2007-10-16 17:59 ` Yinghai Lu
2007-10-16 19:44 ` Jeff Garzik
2007-10-16 18:01 ` Yinghai Lu
2007-10-17 19:43 ` Manfred Spraul
2007-10-02 19:03 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192404972.7014.0.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=aabdulla@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=netdev@vger.kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.