All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ayaz Abdulla <aabdulla@nvidia.com>
To: Jeff Garzik <jgarzik@pobox.com>,
	Manfred Spraul <manfred@colorfullife.com>,
	nedev <netdev@vger.kernel.org>
Subject: MSI interrupts and disable_irq
Date: Thu, 27 Sep 2007 16:42:17 -0400	[thread overview]
Message-ID: <46FC15A9.1070803@nvidia.com> (raw)

I am trying to track down a forcedeth driver issue described by bug 9047 
in bugzilla (2.6.23-rc7-git1 forcedeth w/ MCP55 oops under heavy load). 
I added a patch to synchronize the timer handlers so that one handler 
doesn't accidently enable the IRQ while another timer handler is running 
(see attachment 'Add timer lock' in bug report) and for other processing 
protection.

However, the system still had an Oops. So I added a lock around the 
nv_rx_process_optimized() and the Oops has not happened (see attachment 
'New patch for locking' in bug report). This would imply a 
synchronization issue. However, the only callers of that function are 
the IRQ handler and the timer handlers (in non-NAPI case). The timer 
handlers  use disable_irq so that the IRQ handler does not contend with 
them. It looks as if disable_irq is not working properly.

This issue repros only with MSI interrupt and not legacy INTx 
interrupts. Any ideas?

Thanks,
Ayaz

             reply	other threads:[~2007-09-28 18:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-27 20:42 Ayaz Abdulla [this message]
2007-09-29  2:47 ` MSI interrupts and disable_irq Jeff Garzik
2007-09-29  3:08   ` Stephen Hemminger
2007-10-05 22:12     ` Eric W. Biederman
2007-10-06  6:23       ` Yinghai Lu
2007-10-06 17:43   ` Yinghai Lu
2007-10-06 17:59     ` Jeff Garzik
2007-10-07 16:54       ` Manfred Spraul
2007-10-13  9:30   ` Manfred Spraul
2007-10-14  5:59     ` Yinghai Lu
2007-10-14  7:15       ` Manfred Spraul
2007-10-14 19:55         ` Yinghai Lu
2007-10-14 21:47         ` Benjamin Herrenschmidt
2007-10-14 23:15           ` Yinghai Lu
2007-10-14 23:36             ` Benjamin Herrenschmidt
2007-10-15 22:17     ` Jeff Garzik
2007-10-16 17:23       ` Yinghai Lu
2007-10-16 17:39         ` Jeff Garzik
2007-10-16 17:59           ` Yinghai Lu
2007-10-16 19:44             ` Jeff Garzik
2007-10-16 18:01           ` Yinghai Lu
2007-10-17 19:43             ` Manfred Spraul
2007-10-02 19:03 ` Manfred Spraul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FC15A9.1070803@nvidia.com \
    --to=aabdulla@nvidia.com \
    --cc=jgarzik@pobox.com \
    --cc=manfred@colorfullife.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.